fix: number formatting, route error boundaries, lazy soroban loading, refetch indicator - #505
Merged
ritaifeoluwa merged 1 commit intoSep 26, 2026
Conversation
…oroban loading, and refetch indicator
❌ Deploy Preview for smart-drop failed.
|
|
@ANTIDOT20 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
❌ Deploy Preview for spiffy-melomakarona-eb1e8a failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #496
Closes #497
Closes #498
Closes #499
Changes
formatLockTimeandformatAssetAmountnow share oneIntl.NumberFormat('en-US')formatter. This also stopsformatAssetAmountfrom cutting amounts to 3 decimal places (thetoLocaleString()default); it now keeps up to 7, matching Stellar's precision.error.tsxfor the leaderboard, farm, history, airdrops, alerts, prices, webhooks and contributors routes, all using a sharedRouteErrorcomponent. A crash in one page now shows an inline error with a Try again button while the navbar, footer and other routes stay usable. The farm route's error boundary also covers/farm/[poolId].useSorobanQuery,useLeaderboardandTvlChartload@/lib/sorobanwith a dynamic import when a query first runs, instead of importing the singleton when the module loads, so the RPC client is not created during app boot. Type-only imports remain static.RefetchIndicatorin the app shell: a thin bar at the top of the viewport while queries that already hold data are refetching. First loads do not trigger it, and it is static under reduced motion.Scope notes
@/lib/sorobanstatically (for example formatting helpers) still load it, so the boot-time saving depends on what a page pulls in.src/hooks/useLockFlow.tsalready fails to typecheck onmain(duplicatewalletApiRef); it is untouched here. The rest of the project typechecks with these changes.