Fix profile name in fingerprint for Govee COB Strip Light - #3200
Merged
Conversation
samadDotDev
requested review from
cbaumler,
ctowns,
hcarter-775,
tpmanley and
z-michel
August 28, 2026 05:35
|
Channel deleted. |
|
matter-switch_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 8dcf936 |
Test Results 73 files 541 suites 0s ⏱️ Results for commit 8dcf936. |
cbaumler
approved these changes
Aug 28, 2026
ctowns
approved these changes
Aug 28, 2026
Contributor
Packaging and uploading the driver to a test channel is a part of the current GHA flow, so I am surprised this passed CI. Here is the packaging step for the PR that added this: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/actions/runs/33095683934/job/98599931727 I'm not sure what's different between how that driver is packaged in CI vs. otherwise, but I agree that it would be worth fixing so issues like this don't sneak through. I can investigate further |
Contributor
|
this is what this is for: #3140 |
Contributor
|
@ctowns The driver packaging step does not actually block CI. We can see the channel failure here: https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/actions/runs/33104808024 |
hcarter-775
approved these changes
Aug 28, 2026
JanJakubiszyn
pushed a commit
to JanJakubiszyn/SmartThingsEdgeDrivers
that referenced
this pull request
Sep 1, 2026
cjswedes
pushed a commit
that referenced
this pull request
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was just merged and is causing driver packaging failure.
We should probably add some validation in CI/GHA for this.