Add load testing, disaster recovery, exports, and cohort retention - #900
Conversation
|
@JamesVictor-O is attempting to deploy a commit to the smartdevs17's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@codeX-james Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 15742864 | Triggered | Generic Password | 6d52251 | .github/workflows/backup.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
## Problem `package.json` at the repo root is **not valid JSON**. The `scripts` block is missing a comma after `"release": "semantic-release"` and re-declares `"dev"`, which was already defined a few lines above: ```json "release": "semantic-release" "dev": "turbo run dev" ``` Because the manifest cannot be parsed, npm aborts before resolving a single workspace: ``` npm error JSON.parse Expected ',' or '}' after property value in JSON at position 1790 (line 36 column 5) ``` ## Impact - `npm install` / `npm ci` fail for every contributor. - Any CI job that installs dependencies at the root fails before running. - Frontend tests cannot even load: `vitest.config.ts` resolution walks up to the root manifest and dies with `Expected "," in JSON but found "\"dev\""`. - The broken state is present on `main` (introduced in #900). ## Fix Remove the duplicated `"dev"` key, which leaves the trailing comma issue moot and keeps the first `"dev": "turbo run dev"` definition. ## Verification ```bash python3 -c "import json; json.load(open('package.json'))" # valid npm install --no-audit --no-fund --ignore-scripts # resolves all workspaces ``` With this applied, the root install completes and workspace test tooling becomes runnable. --- 🤖 Generated with Codebuff
3 participants
Summary
Validation
npm --workspace backend exec vitest -- run src/services/reports/report-export.test.ts src/services/__tests__/cohort-analytics.test.ts(16 tests passed)git diff --checkCloses #846
Closes #847
Closes #850
Closes #851