feat(backend): cross-border payments with FX conversion (#920) - #986
Merged
Smartdevs17 merged 1 commit intoSep 28, 2026
Merged
Smartdevs17 merged 1 commit into
Smartdevs17 merged 1 commit into
Conversation
) Enable international transfers end to end: a corridor-aware quote holds an auditable FX rate, and a payment consumes that quote and is settled by the rail. - Add CrossBorderPaymentService with corridor registry, source/target quoting, transparent fee breakdown, rate-hold expiry, and idempotent payments - Add /api/v1/cross-border routes for corridors, quotes, and payments - Mount the cross-border router and the previously unwired FX router - Add unit tests and operational documentation Generated with Codebuff 🤖 Co-Authored-By: Codebuff <noreply@codebuff.com>
|
@sandrawillow001-afk is attempting to deploy a commit to the smartdevs17's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@sandrawillow001-afk Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements cross-border payments end to end: a corridor-aware quote holds an auditable FX rate and converts the amount, and a payment consumes that quote before the settlement rail confirms or rejects it. Composes with the existing FX service (#626).
Closes #920
Changes
CrossBorderPaymentService(backend/src/services/cross-border/):createQuoteinsourceortargetamount mode with a transparent fee breakdown, corridor limits, and a rate-hold expiryinitiatePaymentwith idempotency keys, pluscompletePayment/failPaymentstatus transitions/api/v1/cross-border:corridors,quote,quotes/:id,payments,payments/:id,payments/:id/complete,payments/:id/fail./api/v1/fx.backend/docs/CROSS_BORDER_PAYMENTS.md.Pricing model
Testing
cd backend && npx vitest run src/services/__tests__/cross-border-service.test.ts→ 16 passedtsc --noEmitandeslintclean for all new/changed files