feat(transfers): instant account-to-account transfer rail - #988
Merged
github-actions[bot] merged 2 commits intoSep 28, 2026
Merged
github-actions[bot] merged 2 commits into
github-actions[bot] merged 2 commits into
Conversation
|
@davidsoniaudin2-oss is attempting to deploy a commit to the smartdevs17's projects Team on Vercel. A member of the Team first needs to authorize it. |
…7#913) Adds a real-time A2A transfer service with short-lived quotes that lock fees and FX rates, idempotent initiation to prevent double-charges, per-transfer and rolling 24h velocity limits, cancellation of unsettled transfers, and post-settlement reversals. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
davidsoniaudin2-oss
force-pushed
the
feat/913-instant-account-transfers
branch
from
September 28, 2026 03:46
894c99f to
3296c9b
Compare
|
@davidsoniaudin2-oss Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #913.
Adds a real-time account-to-account transfer rail: accounts are registered and validated before money moves, a short-lived quote locks the fee and FX rate shown to the customer, and transfers are initiated behind an idempotency key so retries never double-charge.
What changed
backend/src/services/transfers.ts—TransferServicewith quote pricing (0.5% fee, 0.50 floor, 25.00 cap), idempotent initiation, per-transfer (25k) and rolling 24h (100k) velocity limits, synchronous instant settlement, cancellation of unsettled transfers, and 24h post-settlement reversals.backend/src/routes/transfers.ts— REST API mounted at/api/v1/transfers(accounts, quotes, transfers, cancel, reverse, volume).backend/src/index.ts— router registration.docs/INSTANT_TRANSFERS.md— feature documentation.Behaviour notes
pendingon the standard rail and can be cancelled.Idempotency-Keyheader or a body field.serviceHandlerwrapper.Tests
backend/src/services/__tests__/instant-transfers.test.ts— 32 tests covering quotes/fees/FX, expiry, idempotency, limits, settlement, cancellation, reversal, and filtering. All passing; typecheck and lint clean for the new files.Verification