feat(auth): OAuth2 PKCE flow for public clients — Issue #806 - #996
Merged
github-actions[bot] merged 1 commit intoSep 28, 2026
Merged
Conversation
|
@Prozaks is attempting to deploy a commit to the smartdevs17's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Prozaks Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- Add PKCE (RFC 7636) support to oauth-service.ts:
generateCodeVerifier() — 43-char URL-safe random verifier
generateCodeChallenge(verifier, method) — S256/plain methods
validateCodeChallenge(verifier, challenge, method)
createPKCEAuthorizationUrl(provider, callbackUrl) — convenience fn
- Extend createOAuthAuthorizationUrl with optional pkce param
- Extend exchangeOAuthCode with optional codeVerifier validation
- Add GET /:provider/pkce route returning { url, codeVerifier }
- Update callback route to pass PKCE params through
- 22 tests covering all PKCE paths (S256, plain, validation errors)
Closes Smartdevs17#806
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the existing OAuth2 service with PKCE (RFC 7636) support for public clients that cannot safely store a client secret.
Changes
src/services/oauth-service.tsNew exports added (backwards-compatible):
generateCodeVerifier()— 43-char cryptographically secure URL-safe verifier (randomBytes(32).base64url)generateCodeChallenge(verifier, method)— S256 (SHA-256 base64url) or plainvalidateCodeChallenge(verifier, challenge, method)— validates verifier against stored challengecreatePKCEAuthorizationUrl(provider, callbackUrl, redirectTo?)— convenience helper returning{ url, codeVerifier }createOAuthAuthorizationUrlextended with optional 4thpkceparameterexchangeOAuthCodeextended with optionalcodeVerifiervalidationsrc/routes/oauth.tsGET /:provider/pkceroute — returns{ url, codeVerifier }for PKCE flow initiationPKCE flow
Test results
Closes #806