feat: expose X11 window icons - #2160
Open
FreddyFunk wants to merge 2 commits into
Open
Conversation
This was referenced Sep 8, 2026
Drakulix
reviewed
Sep 8, 2026
| title: String, | ||
| class: String, | ||
| instance: String, | ||
| icons: Vec<X11SurfaceIcon>, |
Member
There was a problem hiding this comment.
Thanks! Can we avoid permanently storing the pixel data in each X11Surface?
If a compositor decides to this (e.g. via UserData), that is one thing. But I think smithay should simply notify the compositor, when there is new image data and then fetch the data upon request from Xwayland.
Author
There was a problem hiding this comment.
Yes, that's a way better design. I implemented it now according to your suggestion.
FreddyFunk
force-pushed
the
feat/x11-window-icons
branch
from
September 10, 2026 17:47
a4aca9e to
6f38229
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Parse bounded
_NET_WM_ICONimage records and expose all valid sizes throughX11Surface. Advertise and report runtime icon property updates and removals. This allows compositors to properly propagate window metadata.I noticed that icons and application names are not properly shown for video games launched through Steam in COSMIC dock. This is one of the building blocks to make it work.
Checklist