Conversation
…ssions Previously, destroying the capture session wouldn't destroy the cursor session and fail the frames like it does when destroying the cursor session itself, or regular sessions.
This was referenced Sep 12, 2026
pgaskin
added a commit
to pgaskin/niri
that referenced
this pull request
Sep 12, 2026
Contributor
Author
|
Not directly related to this PR, but @ids1024 may be interested in niri-wm/niri#4554 (comment) (cosmic implements frame handling on session destruction differently than the others). |
ids1024
reviewed
Sep 15, 2026
| inner: Arc<Mutex<CursorSessionInner>>, | ||
| user_data: Arc<UserDataMap>, | ||
| /// Cursor session to destroy. | ||
| cursor_obj: Option<ExtImageCopyCaptureCursorSessionV1>, |
Member
There was a problem hiding this comment.
Instead of using Option, it would probably make sense to split CursorSessionData into two types; one used to implement dispatch for ExtImageCopyCaptureSessionV1 and another for ExtImageCopyCaptureSessionV1?
I would also make this a Weak<ExtImageCopyCaptureCursorSessionV1> if we don't need a strong reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, destroying the capture session wouldn't destroy the cursor session and fail the frames like it does when destroying the cursor session itself, or regular sessions.
Tested with niri-wm/niri#4554.
cc @YaLTeR
Checklist