Skip to content

backend/input(winit): translate pinch and hold gestures into input ev… - #2172

Open
Atan-D-RP4 wants to merge 1 commit into
Smithay:masterfrom
Atan-D-RP4:winit-gesture-events
Open

Atan-D-RP4 wants to merge 1 commit into
Smithay:masterfrom
Atan-D-RP4:winit-gesture-events

Conversation

@Atan-D-RP4

@Atan-D-RP4 Atan-D-RP4 commented Sep 13, 2026

Copy link
Copy Markdown

Description

#2156 added support for Wayland Pinch, Pan, and Rotation gestures. This is the Smithay side wiring for them. Or at least the first iteration of it.

With this, I can test:

in a nested niri winit-window.

AI Disclosure: AI was used to research the problem and point me to relevant code and issues with my own. The actual fix and text written are solely my own. Please let me know if that disqualifies the PR, happy to have it taken down if it does.

Checklist

fn has_capability(&self, capability: DeviceCapability) -> bool {
matches!(
capability,
DeviceCapability::Keyboard | DeviceCapability::Pointer | DeviceCapability::Touch

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to add DeviceCapability::Gesture here now.

@ids1024

ids1024 commented Sep 16, 2026

Copy link
Copy Markdown
Member

For some reason I don't seem to see anvil clients getting gesture events with this even after using const HAS_GESTURES: bool = true; in impl Backend for WinitData {.

@ids1024

ids1024 commented Sep 16, 2026

Copy link
Copy Markdown
Member

Oh, I suppose for Anvil process_input_event_windowed also needs to be updated.

@Atan-D-RP4

Atan-D-RP4 commented Sep 16, 2026

Copy link
Copy Markdown
Author

Ah, then should this PR include that work? I haven't done any messing around or testing with Anvil, just Niri.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants