fix(actionbar): port vanilla interactions to 26.2 by bigyasso730 · Pull Request #63 · Smithed-MC/Libraries

bigyasso730 · 2026-08-15T15:54:44Z

Overview

Fixes #62

This PR fixes vanilla Actionbar block interaction detection and ports the
affected Actionbar advancements to the Minecraft 26.2 data pack format.

Problem

The Actionbar library currently uses minecraft:item_used_on_block to
detect interactions with vanilla blocks.

This is too restrictive for reproducing vanilla Actionbar behavior.
For example, right-clicking a lockable block with a stick does not trigger
item_used_on_block, while placing a block does.

As a result, some legitimate block interactions do not produce the expected
Actionbar message.

Changes

Replace minecraft:item_used_on_block with minecraft:any_block_use
where generic block interaction is required.
Remove redundant empty-hand criteria using minecraft:air.
Remove the now-unnecessary requirements sections where only a single
criterion remains.
Keep separate occupied and unoccupied criteria for beds.
Update block predicates from tag to blocks.
Update the legacy Lock block data field to lock.
Remove the obsolete top-level conditions.location from
slept_in_bed.json.

Bed interactions

clicked_bed.json previously had four criteria:

unoccupied
occupied
unoccupied_empty
occupied_empty

The empty-hand criteria were removed because any_block_use can detect
the block interaction directly.

The advancement now has two criteria:

unoccupied
occupied

This preserves the distinction needed by the Actionbar implementation
while avoiding duplicate interaction criteria.

Lockable blocks

clicked_lockable_block.json now uses a single any_block_use criterion.

It checks that:

the player is not sneaking;
the Actionbar library version is loaded; and
the interacted block belongs to the lockable block tag.

The previous empty-hand criterion and requirements section are no longer
needed.

26.2 compatibility

The affected block predicates have been updated from:

"tag": "..."

to:

"blocks": "#..."

The container lock check has also been updated from the legacy Lock
block data field to the current lock field.

The slept_in_bed advancement no longer uses the obsolete top-level
conditions.location field.

Testing

Tested the Actionbar interactions for:

Right-clicking lockable blocks with a stick.
Placing blocks against lockable blocks.
Empty-hand interactions.
Sneaking interactions.
Occupied beds.
Unoccupied beds.
Sleeping in beds in the Overworld.

The Actionbar library also builds successfully with Beet.

clicked_bed.json 26.2 porting and restrictive fix

slept_in_bed.json 26.2 port and restrictive fix

clicked_lockable_block 26.2 port and restrictive fx

check_lock.mcfunction 26.2 port and capitaization fix

east.mcfunction 26.2 port and capitalization fix

north.mcfunction 26.2 port and capitalization fix

south.mcfunction 26.2 port and capitalization fix

west.mcfunction 26.2 port and capitalization fix

clicked_bed.mcfunction removed occupied_empty check due to optimizations in clicked_bed.json advancement file.

Action bar 26.2

bigyasso730 · 2026-08-15T18:15:24Z

I apologize for the accidental Merge pull request from commit 10, if this pull request is merged, can it be squashed first?

edayot

Changes looks good to me, some problems needs to be solved.

If you need help for the beet setup, feel free to ask on the discord server.

Note for myself : I DID NOT TEST ANYTHING INGAME

PS: on merge we will definitely squash commits

edayot · 2026-08-15T21:27:58Z

  ],
  "rewards": {
-    "function": "smithed.actionbar:impl/vanilla/bed/clicked_bed"
+    "function": "smithed.actionbar:v0.7.0/vanilla/bed/clicked_bed"


the impl/ is automaticly replace in the beet pipeline, pls rollback this change

edayot · 2026-08-15T21:28:42Z

            "predicate": {
              "block": {
-                "tag": "smithed.actionbar:impl/lockable"
+                "blocks": "#smithed.actionbar:v0.7.0/lockable"


same here, rollback the impl change

edayot · 2026-08-15T21:29:01Z

-  ],
  "rewards": {
-    "function": "smithed.actionbar:impl/vanilla/container/clicked_lockable_block"
+    "function": "smithed.actionbar:v0.7.0/vanilla/container/clicked_lockable_block"


edayot · 2026-08-15T21:29:14Z

            "predicate": {
              "block": {
-                "tag": "smithed.actionbar:impl/lockable"
+                "blocks": "#smithed.actionbar:v0.7.0/lockable"


edayot · 2026-08-15T21:45:10Z

+      "trigger": "minecraft:default_block_use",
      "conditions": {
        "player": [
+          {


same as above

edayot · 2026-08-15T21:45:36Z

                "min": 1
              }
            }
+          },


same as above

Hello, I apologize for the load_status and impl changes, I accidentally used the compiled version, I fixed them, if you need any other changes I'm here to help.

edayot · 2026-08-16T18:06:03Z

only part for raw string, that should not be quoted or having colors, nobody use them, it's not a big deal

edayot · 2026-08-16T18:11:05Z

Thank you for your contribution, i tested in-game and it was working fine for both of them !

… + bump (custom-block & crafter) to support 26.2 * Update clicked_bed.json clicked_bed.json 26.2 porting and restrictive fix * Update slept_in_bed.json slept_in_bed.json 26.2 port and restrictive fix * Update clicked_lockable_block.json clicked_lockable_block 26.2 port and restrictive fx * Update check_lock.mcfunction check_lock.mcfunction 26.2 port and capitaization fix * Update east.mcfunction east.mcfunction 26.2 port and capitalization fix * Update north.mcfunction north.mcfunction 26.2 port and capitalization fix * Update south.mcfunction south.mcfunction 26.2 port and capitalization fix * Update west.mcfunction west.mcfunction 26.2 port and capitalization fix * Update clicked_bed.mcfunction clicked_bed.mcfunction removed occupied_empty check due to optimizations in clicked_bed.json advancement file. * Update clicked_bed.json * Update slept_in_bed.json * Update clicked_lockable_block.json * fix: raw message should not have quotes nor colors * chore: bumping libs and minecraft version --------- Co-authored-by: edayot <pro.e.dayot@gmail.com>

bigyasso730 added 10 commits August 15, 2026 17:55

Update clicked_bed.json

99ed4f9

clicked_bed.json 26.2 porting and restrictive fix

Update slept_in_bed.json

74c89e1

slept_in_bed.json 26.2 port and restrictive fix

Update clicked_lockable_block.json

51eb818

clicked_lockable_block 26.2 port and restrictive fx

Update check_lock.mcfunction

8d2d27e

check_lock.mcfunction 26.2 port and capitaization fix

Update east.mcfunction

6f54602

east.mcfunction 26.2 port and capitalization fix

Update north.mcfunction

4bdfaae

north.mcfunction 26.2 port and capitalization fix

Update south.mcfunction

d71419b

south.mcfunction 26.2 port and capitalization fix

Update west.mcfunction

43d702e

west.mcfunction 26.2 port and capitalization fix

Update clicked_bed.mcfunction

2d20591

clicked_bed.mcfunction removed occupied_empty check due to optimizations in clicked_bed.json advancement file.

Merge pull request #1 from bigyasso730/action-bar-26.2

160d92b

Action bar 26.2

bigyasso730 changed the title ~~26.2~~ fix(actionbar): port vanilla interactions to 26.2 Aug 15, 2026

edayot requested changes Aug 15, 2026

View reviewed changes

bigyasso730 added 3 commits August 16, 2026 09:47

Update clicked_bed.json

ebc1b38

Update slept_in_bed.json

d4711b8

Update clicked_lockable_block.json

a77d5db

bigyasso730 requested a review from edayot August 16, 2026 14:10

edayot added 2 commits August 16, 2026 19:58

fix: raw message should not have quotes nor colors

2a00d89

chore: bumping libs and minecraft version

638a567

edayot approved these changes Aug 16, 2026

View reviewed changes

edayot merged commit af54ac0 into Smithed-MC:main Aug 16, 2026
1 check passed

Uh oh!

Conversation

bigyasso730 commented Aug 15, 2026

Overview

Problem

Changes

Bed interactions

Lockable blocks

26.2 compatibility

Testing

Uh oh!

bigyasso730 commented Aug 15, 2026

Uh oh!

edayot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

edayot commented Aug 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

edayot left a comment •

edited

Loading