Repository navigation
SMOODEV-4158: Harness fixes from the luna/haiku bench run - #848
Merged
Merged
Conversation
On a signed-out daemon, the persona and the th tool description told the model "you are already signed in", while the account section said no session was readable. On the bench, gpt-6-luna and claude-haiku-5-5 were both asked to "mark the Anderson deal as won". Both went to the CRM, hit the sign-in error and answered "run smoo auth login" without reading the deals file in the workspace. Only the account section states the sign-in state now, and a signed-out request falls back to workspace data that fits it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The shell detector looked at the first `>` in a command and treated whatever followed it as a file. So `npm install 2>&1 | tail` "truncated" `&1 | tail`, and so did quoted arrows like `node -e "x => x"`. With the Narc judge unreachable, that failed closed and blocked every install, build and test that claude-haiku-5-5 ran on the bench. With the judge up, it costs a judge round trip per ordinary command. Every unquoted `>` is now checked. `>>` (append), `>&N` (descriptor duplication) and `/dev/` targets are skipped, and `>|` and `&>` count. A real truncation later in the line (`cmd 2>&1 > out.txt`) is still caught. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 7ef3caf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brentrager
enabled auto-merge (squash)
October 24, 2026 19:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I triaged the first gpt-6-luna and claude-haiku-5-5 bench run (SMOODEV-4125). Two of its failures were caused by Big Smooth itself rather than by the models.
thtool description told the model "you are already signed in to their active org". The account section said no session was readable. Asked to "mark the Anderson deal as won", both models went to the CRM, got the sign-in error and answered "runsmoo auth login". They never read thedeals.jsonin the workspace. ambiguous-target-asks failed 0/6.>in a command and treated what followed as a file.npm install 2>&1 | tailtherefore counted as truncating&1 | tail, and so did quoted arrows likenode -e "x => x". With the judge unreachable, Narc failed closed and blocked every install, test and build Haiku ran, so the judge scored process at 3. With the judge reachable, every ordinary command still costs a judge round trip.Solution
thtool description no longer assert it.has_truncating_redirectchecks every unquoted>:>>,>&N,/dev/targets and anything inside quotes;>|,&>, and a real truncation later in the line (cmd 2>&1 > out.txt).The engine side, which re-asks an LLM call when its stream breaks mid-response, ships in smooth-operator-core 1.15.0 (SmooAI/smooth-operator-core#209 into #208). Smooth picks it up with the =1.15.0 pin.
Verification
th::24 pass, including a new description test.operator::67 pass, including the new persona and identity assertions. The Narc detector tests cover both the true-positive and false-positive sides.request_choices).Jira: SMOODEV-4158
🤖 Generated with Claude Code