Repository navigation
SMOODEV-4160: th attest reuses a pass while inputs are unchanged - #851
Merged
Merged
Conversation
…changed Re-attesting after a rebase or a docs-only commit re-ran every row for minutes in a contended queue. A local pass ledger (~/.smooth/attest/credits.db) now credits a row from a recent passing commit when the repo's scripts/ci/_rows-touched.sh says nothing between them touches it, or the diff is empty. Check-definition changes, dirty trees and --no-reuse always run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UApL5uBTfZnkfrXRhXTYSo
🦋 Changeset detectedLatest commit: 9f4e3c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brentrager
enabled auto-merge (squash)
October 25, 2026 00:55
…mon test deletes it th_without_a_daemon_says_so_in_two_lines deleted flow.addr right after the rig saw the 'listening' line, but the daemon claims flow.addr after that line, so the file could reappear and th harness list found a daemon (CI failed twice). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UApL5uBTfZnkfrXRhXTYSo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Re-attesting after a rebase, a docs-only commit or a review fixup re-runs every row, often 20–50 min in the contended machine-wide ci-queue, even when nothing a row reads changed. The idea comes from dagger's content-addressed
@checkcache.Solution
attest/reuse.rs: a local pass ledger (SQLite WAL,~/.smooth/attest/credits.db, keyed by repo common-dir + check + sha; 72h max age viaREUSE_MAX_HOURS).scripts/ci/_rows-touched.shsays the row isuntouched. The hook gets 10s and must exit 0.scripts/ci/always runs the row. A dirty tree,--no-reuse,SMOOTH_CI_NO_REUSE/SMOOAI_CI_NO_REUSEand failures are never reused.passed locally in Ns (reused from abc1234: no input changed); JSON addsreused_from.scripts/ci/_rows-touched.sh) landed in SmooAI/smooai#6448.Verification
cargo clippy -p smooai-smooth-cli --all-targets: cleancargo test -p smooai-smooth-cli --bin th attest::: 126 passed (new: same-commit re-attest, hook untouched/touched, no hook, check-definition change,--no-reuse, failure never reused, dirty run, status/description name the source commit, hook memo, hook timeout)Jira: https://smooai.atlassian.net/browse/SMOODEV-4160
🤖 Generated with Claude Code
https://claude.ai/code/session_01UApL5uBTfZnkfrXRhXTYSo