Skip to content

Feature render optimize#463

Open
Kenshin627 wants to merge 5 commits into
mainfrom
feature_render_optimize
Open

Feature render optimize#463
Kenshin627 wants to merge 5 commits into
mainfrom
feature_render_optimize

Conversation

@Kenshin627

@Kenshin627 Kenshin627 commented Jun 10, 2026

Copy link
Copy Markdown

Summary

this PR add cpuSide glVolume Frustum culling, toolbar render refactor, with constant buffer and transfromMatrix

Changes

  1. camera frustum create/update
  2. frustum/aabb intersectionTest
  3. cpu frustum culling
  4. toolbar render refactor

Comment thread resources/shaders/140/background.vs Outdated
void main()
{
tex_coord = v_tex_coord;
tex_coord = tex_coord = v_position.xy * 0.5 + 0.5;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

双重赋值

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

}

float scale = 1.0f;
if (n1.x() != 0.0f)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是否需要用容差判断


for (GLVolumeWithIdAndZ& volume : to_render) {
//CPU Frustum culling
auto _worldAABB = volume.first->transformed_bounding_box();

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

变量名不符合规范

Comment thread src/slic3r/GUI/Camera.hpp
#include "libslic3r/BoundingBox.hpp"
#include "3DScene.hpp"
#include <array>
#include "../Utils/Frustum.hpp"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不建议使用相对路径,直接用 #include "Utils/Frustum.hpp"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants