Feature top cover yjx#465
Open
iesteem wants to merge 9 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…ing detection The solid_infill_filament key was missing from p->config's default key list, causing collect_filament_slots_from_config() to never detect solid infill filament usage. This made the high/low temperature mixing guard silently skip solid infill while correctly catching all other auxiliary materials. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
check_filament_temp_mixing incorrectly used the Plater's global config (p->config) when checking per-plate filament temperature mixing. This caused false positives on plates that don't use mixing when a 3MF project contains both mixed and non-mixed plates. Remove the global config collection and instead resolve the default extruder for objects with extruder=0 from full_config(), so only the filament slots actually used by each plate's objects are considered. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Sync main tab with view panel in select_view_3D via select_tab - Skip redundant GL toolbar event post when view already matches tab - Allow Preview tab switch when plate is blocked by temp mixing - Always re-push filament temp mixing notification to handle external dismiss Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…ions Replace wxMessageDialog with MessageDialog in both mixing confirm functions to match the "High and Low Temperature Material Mixing Risk" dialog style in Preferences. Change dialog title to "Confirm slicing" with custom Confirm/Cancel button labels. Add Chinese translations for "Confirm slicing" and the mixing risk message text. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
iesteem
force-pushed
the
feature_top_cover_yjx
branch
from
2d95951 to
62454d9
Compare
| return;} | ||
| #endif | ||
| if (evt.CmdDown() && evt.GetKeyCode() == 'R') { if (m_slice_enable) { wxGetApp().plater()->update(true, true); wxPostEvent(m_plater, SimpleEvent(EVT_GLTOOLBAR_SLICE_PLATE)); this->m_tabpanel->SetSelection(tpPreview); } return; } | ||
| if (evt.CmdDown() && evt.GetKeyCode() == 'R') { if (m_slice_enable) { wxGetApp().plater()->update(true, true); wxPostEvent(m_plater, SimpleEvent(EVT_GLTOOLBAR_SLICE_PLATE)); } return; } |
…g check The global Plater config's wall_filament/solid_infill_filament etc. were unconditionally collected for every plate, causing false positives when a filament assigned in the global config was not actually used on a given plate (e.g., solid_infill_filament=3(ABS) flagged Plate 2 which only used extruder=0(PLA-AERO)). Remove collect_filament_slots_from_config(*this->config(), ...) so the per-plate check only considers plate-level overrides, object/volume extruder assignments, and global default extruder resolution. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description