fix: Prevent invalid part instance from autonexting - #1794
Draft
PeterC89 wants to merge 6 commits into
Draft
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughInvalid next ChangesInvalid next-part playout handling
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant PlayoutPlayback
participant handleOnPlayoutPlaybackChanged
participant onPartPlaybackStarted
participant RundownTiming
participant NotificationCenter
PlayoutPlayback->>handleOnPlayoutPlaybackChanged: report next PartInstance playback
handleOnPlayoutPlaybackChanged->>onPartPlaybackStarted: process playback start
onPartPlaybackStarted->>onPartPlaybackStarted: check invalidReason
onPartPlaybackStarted-->>handleOnPlayoutPlaybackChanged: throw TakePartInstanceInvalid
RundownTiming->>RundownTiming: compute blocked auto-next state
RundownTiming->>NotificationCenter: push critical notification once
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
PeterC89
added
🐛🔨 bugfix
Contributor
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
PeterC89
marked this pull request as ready for review
July 14, 2026 11:30
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/webui/src/client/ui/SegmentTimeline/SegmentTimelineContainer.tsx`:
- Line 728: Update the currentPartAutoNextBlockedByInvalidReason prop assignment
in SegmentTimelineContainer to read from this.context?.durations, preserving the
existing false fallback and matching the access path used by other timing reads.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 54aaa405-c76c-4cc6-b577-f04a671ca33c
📒 Files selected for processing (6)
packages/webui/src/client/lib/rundownTiming.tspackages/webui/src/client/ui/RundownView/RundownTiming/AutoNextStatus.tsxpackages/webui/src/client/ui/RundownView/RundownTiming/RundownTimingProvider.tsxpackages/webui/src/client/ui/SegmentTimeline/Parts/SegmentTimelinePart.tsxpackages/webui/src/client/ui/SegmentTimeline/SegmentTimeline.tsxpackages/webui/src/client/ui/SegmentTimeline/SegmentTimelineContainer.tsx
PeterC89
marked this pull request as draft
July 15, 2026 09:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the BBC.
Type of Contribution
This is a: Bug fix
Current Behavior
Manual takes are blocked by invalid part instances but auto-takes are not.
New Behavior
Auto-takes are blocked for invalid part instances.
Testing
Affected areas
This PR affects the playout logic in general.
Time Frame
Not urgent, but we would like to get this merged into the in-development release.
Other Information
Written with the assistance of GitHub Copilot
Status