Repository navigation
New storage layout without tables - #242
Open
SharonStrats wants to merge 8 commits into
Open
SharonStrats wants to merge 8 commits into
SharonStrats wants to merge 8 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Nested-container rendering, resource refreshes, responsive layout, and asynchronous selection handling have unresolved defects.
Review effort: Balanced
Findings: 1
Open (9)
What changed in this PR
Replaces the legacy table-based folder pane with a component-based storage browser containing sidebar navigation and content views.
Changes:
- Adds resource-loading and content-rendering helpers.
- Introduces Lit storage sidebar, pane, and container components.
- Adds layout styling and Lucide icon support.
| File | Description |
|---|---|
src/types.ts |
Adds shared resource and renderer types. |
src/helpers.ts |
Adds container and content-rendering helpers. |
src/folderPane.ts |
Integrates the new storage pane. |
src/styles/folderPane.css |
Replaces table styles with flex layout. |
src/components/storage-sidebar/StorageSidebar.ts |
Implements resource-tree navigation. |
src/components/storage-sidebar/StorageSidebar.styles.css |
Styles sidebar rows and icons. |
src/components/storage-sidebar/index.ts |
Exports the sidebar. |
src/components/storage-pane-view/StoragePaneView.ts |
Coordinates sidebar selection and content. |
src/components/storage-pane-view/StoragePaneView.styles.css |
Adds pane section styles. |
src/components/storage-pane-view/index.ts |
Adds the pane-view barrel export. |
src/components/storage-content-view/StorageContentView.ts |
Adds the slotted content host. |
src/components/storage-content-view/StorageContentView.styles.css |
Adds a content-view style placeholder. |
src/components/storage-content-view/index.ts |
Exports the content view. |
src/components/container-content-view/ContainerContentView.ts |
Renders container resources. |
src/components/container-content-view/ContainerContentView.styles.css |
Adds a container style placeholder. |
src/components/container-content-view/index.ts |
Adds the container-view barrel export. |
package.json |
Adds icon data and side-effect metadata. |
package-lock.json |
Locks the icon dependency. |
declarations.d.ts |
Declares CSS and virtual icon modules. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
SharonStrats
force-pushed
the
task/restructure
branch
from
September 27, 2026 12:07
8fba9b7 to
f274e70
Compare
timea-solid
reviewed
Oct 2, 2026
timea-solid
left a comment
timea-solid
left a comment
Member
There was a problem hiding this comment.
how is refresh handeled now?
and i see you also do not need GotoSubject ?
SharonStrats
force-pushed
the
task/restructure
branch
from
October 3, 2026 12:23
e405414 to
3fa8fe5
Compare
Prompt: Use the get relevant pane function from solid-ui Co-authored-by: GPT-5.6 Luna <gpt-5.6-luna@openai.com>
SharonStrats
marked this pull request as draft
October 18, 2026 11:32
SharonStrats
changed the title
SharonStrats
force-pushed
the
task/restructure
branch
2 times, most recently
from
October 19, 2026 05:21
12a5ad9 to
6d5e990
Compare
SharonStrats
force-pushed
the
task/restructure
branch
from
October 19, 2026 11:55
e02a5dc to
374606b
Compare
Member
|
p.s What is the search top right supposed to do? On your server, it does nothing. We could leave it off for now. |
Member
|
A bug: |
SharonStrats
force-pushed
the
task/restructure
branch
from
October 21, 2026 04:57
d122fa9 to
188ca73
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved routing, write-destination, and asynchronous refresh defects affect core storage workflows.
10 open issues
9 resolved since last review
Review effort: Balanced
SharonStrats
force-pushed
the
task/restructure
branch
from
October 22, 2026 05:49
2ad99ca to
3ace63b
Compare
Prompt: Various prompts such as progressively load the data for the container view, implement recoverable loading and discovery, handle creation so that it does not add a sidebar list entry when it was not created. Co-authored-by: GPT-5.6 Luna <gpt-5.6-luna@openai.com>
SharonStrats
force-pushed
the
task/restructure
branch
from
October 22, 2026 08:50
18fe878 to
eb8dc32
Compare
…@5.0.2-2) (latest: rdflib@2.4.1)
SharonStrats
marked this pull request as ready for review
October 22, 2026 10:02
timea-solid
approved these changes
Oct 22, 2026
| private isRootSpecialFolder (resource: Resource) { | ||
| if (!resource.isContainer) return false | ||
| const label = utils.label(resource.subject).toLowerCase() | ||
| return label === 'public' || label === 'trash' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had trouble making it simple and getting things to work and making it look presentable, so I decided to pull the basic stuff over from the prototype. There is no real new functionality. Nothing added to 3dot menu, no extra drag and drop features with the folders or content area...
I took on all the feedback from the prototype and also renaming things here and implemented it.
Some examples