Repository navigation
Sync/main from staging - #244
Merged
Merged
Conversation
fix dev login to match new authn
…@3.1.3-4) (latest: rdflib@2.3.9)
…er-pane into solidosDependencies
Solidos dependencies
…@3.1.3-9) (latest: rdflib@2.4.0)
…@3.1.3-11) (latest: rdflib@2.4.0)
…-pane into feat/migrate-vite
…@3.1.3-11) (latest: rdflib@2.4.0)
Migrate to Vite #225
…@3.1.3-13) (latest: rdflib@2.4.0)
…@3.1.3-14) (latest: rdflib@2.4.0)
Fix the problem with uploading files with the plus
…@3.1.3-17) (latest: rdflib@2.4.0)
Staging version
…@5.0.0-0) (latest: rdflib@2.4.0)
…@5.0.0-0) (latest: rdflib@2.4.0)
Improve look on mobile for release
…@5.0.0-0) (latest: rdflib@2.4.0)
…6.0.0 solid-ui@5.0.1)
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The CI workflow has mutable privileged dependencies, excessive secret forwarding, and a race-prone branch checkout.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Migrates folder-pane from Webpack to the shared Vite toolkit, updates packaging for v4, and expands the upload drop zone.
Changes:
- Replaces Webpack/Babel configuration with Vite.
- Moves build outputs to
distand updates dependencies. - Revises styling, drag-and-drop, and CI publishing.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Adds dependency updates and OIDC publishing. |
.gitignore |
Ignores dist. |
babel.config.mjs |
Removes obsolete Babel configuration. |
dev/context.js |
Removes legacy development context. |
dev/dev-global.css |
Removes legacy development styles. |
dev/index.html |
Removes Webpack development page. |
dev/index.js |
Removes Webpack development entry point. |
package.json |
Updates v4 packaging, scripts, and dependencies. |
src/folderPane.ts |
Expands the file drop target. |
src/index.ts |
Adds the Vite library entry point. |
src/styles/folderPane.css |
Revises layout and drop-zone styling. |
tsconfig.json |
Adopts bundler resolution and dist output. |
vite.config.mts |
Adds shared Vite build and sandbox configuration. |
webpack.config.mjs |
Removes production Webpack configuration. |
webpack.dev.config.mjs |
Removes development Webpack configuration. |
webpack.module.rules.mjs |
Removes Webpack loader rules. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+19
to
+20
| uses: SolidOS/solidos/.github/workflows/update-solidos-deps.yml@main | ||
| secrets: inherit |
| # fork PRs keep the default commit, as the updater deliberately does not commit there. | ||
| - uses: actions/checkout@v6 | ||
| with: | ||
| ref: ${{ github.event_name == 'pull_request' && (github.event.pull_request.head.repo.fork && github.sha || github.head_ref) || github.ref_name }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.