Skip to content

Display storage from new design - #473

Merged
SharonStrats merged 4 commits into
stagingfrom
fix-browserhtml
Oct 25, 2026
Merged

SharonStrats merged 4 commits into
stagingfrom
fix-browserhtml

Conversation

@SharonStrats

@SharonStrats SharonStrats commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

My computer is not allowing me to copy a screenshot sorry, I have over worked it LOL. but it looks exactly like the storage from the main app, just when the bar, then the account login and below storage.

I had to make a couple other changes because the profile heading was not appearing when viewing a webid.

…pp view class for styling

Prompt: The browser html should show the full folder view with heading, sidebar and content

Co-authored-by: GPT-5.6 Luna <gpt-5.6-luna@openai.com>
@SharonStrats
SharonStrats requested review from bourgeoa and timea-solid and a balanced review from Copilot October 25, 2026 06:37
@SharonStrats SharonStrats self-assigned this Oct 25, 2026
@SharonStrats SharonStrats moved this to In review in SolidOS NLNet UI Oct 25, 2026
@SharonStrats SharonStrats linked an issue Oct 25, 2026 that may be closed by this pull request

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

URI normalization changes valid extensionless document and WebID addresses, causing navigation to different resources.

1 open issue
What changed in this PR

This PR brings the storage explorer layout to the standalone browser page and adjusts rendering around authentication and environment changes.

Changes:

  • Enables explorer-style folder rendering with URL preservation.
  • Adds URI normalization and authentication-triggered rendering.
  • Limits environment-triggered UI refreshes to the main browser entry point.
File Description
static/​browse.html Adds explorer rendering, authentication refresh handling, URI normalization, and app-view styling.
src/​index.ts Guards UI refreshes so environment changes do not replace standalone browser content.

Review effort: Balanced

Comment thread static/browse.html Outdated
@SharonStrats
SharonStrats force-pushed the fix-browserhtml branch 2 times, most recently from ee82b7b to 11fecb6 Compare October 25, 2026 07:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Redirect handling can replace a non-container RDF subject with its description-document URL, causing navigation to display the wrong resource.

1 open issue
1 resolved since last review

Review effort: Balanced

Comment thread static/browse.html Outdated
…@5.0.2-3 pane-registry@5.0.2-1 solid-panes@5.1.0-2) (latest: rdflib@2.4.1)
…@5.0.2-3 pane-registry@5.0.2-1 solid-panes@5.1.0-3) (latest: rdflib@2.4.1)
@SharonStrats
SharonStrats merged commit 6bf347c into staging Oct 25, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in SolidOS NLNet UI Oct 25, 2026
@SharonStrats
SharonStrats deleted the fix-browserhtml branch October 25, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Browse.html

3 participants