Repository navigation
#422 Fix comboboxes - #428
Merged
Merged
Conversation
Closed
NoelDeMartin
force-pushed
the
422-comboboxes
branch
3 times, most recently
from
July 8, 2026 15:08
1c57370 to
0a17eba
Compare
NoelDeMartin
marked this pull request as ready for review
July 8, 2026 15:13
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Skills, Resume, and Language edit dialogs to use the new solid-ui Combobox async options API (via defineAsyncComboboxOptionsProvider, asyncOptionsProvider, and optionsFallback), replacing the older per-element suggestion plumbing.
Changes:
- Migrate Skills/Resume/Language comboboxes to async options providers and new Combobox types/events.
- Simplify combobox initialization by using
optionsFallback+valueinstead of manually syncing shadow-input state. - Update combobox templates/handlers to use
ComboboxChangeEventoption payloads and set placeholders.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/sections/skills/SkillsEditDialog.ts | Switch skills combobox to async provider + new change event option payloads. |
| src/sections/resume/ResumeEditDialog.ts | Switch resume organization combobox to async provider + new selected-option handling. |
| src/sections/languages/LanguageEditDialog.ts | Switch languages combobox to async provider and enforce select-only selection flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NoelDeMartin
force-pushed
the
422-comboboxes
branch
from
July 9, 2026 08:08
0a17eba to
1cdacf0
Compare
timea-solid
approved these changes
Jul 13, 2026
timea-solid
left a comment
timea-solid
left a comment
Member
There was a problem hiding this comment.
LGTM - really great, thanks for switching and improving this!
NoelDeMartin
force-pushed
the
422-comboboxes
branch
from
July 14, 2026 08:02
1cdacf0 to
b747c60
Compare
NoelDeMartin
force-pushed
the
422-comboboxes
branch
from
July 14, 2026 08:23
b747c60 to
27d43dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is blocked by the following PRs: