Repository navigation
Component fixes - #825
Merged
Merged
Component fixes#825
Conversation
The previous implementation worked in Firefox, but not in Chrome. Apparently, the :host() selector does not include the light DOM when it's evaluated in Chrome, so the only way to implement this is to prepare it in JavaScript.
- Listen to mousedown instead of mouseup to select option (the previous implementation was hiding the options in dialogs because the dialog got focused during mousedown, triggering handleDocumentFocusIn). - Reset filter when options are hidden, in order to improve the UX when the list is open again.
timea-solid
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.