Repository navigation
Fix the login - #904
Closed
SharonStrats wants to merge 2 commits into
Closed
Fix the login#904SharonStrats wants to merge 2 commits into
SharonStrats wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The module-local tag registry rejects registered dialog constructors passed between library copies.
1 open issue
What changed in this PR
This PR adjusts authentication context and dialog creation to support multiple loaded copies of solid-ui.
Changes:
- Uses a shared symbol for the authentication context.
- Records custom-element tag names and creates dialogs by tag name.
- Updates the expected public exports in the index test.
| File | Description |
|---|---|
test/unit/index.test.ts |
Adds the tag-name helper to expected exports. |
src/lib/dialogs/helpers.ts |
Creates dialog elements using their registered tag names. |
src/lib/components/decorators.ts |
Records and exposes component tag names. |
src/lib/auth/context.ts |
Shares the authentication context key across library copies. |
Review effort: Balanced
| * See https://github.com/SolidOS/solidos/issues/300 | ||
| */ | ||
|
|
||
| const customElementTagNames = new WeakMap<CustomElementConstructor, string>() |
Collaborator
Author
|
this is not the right fix, dependency alignment for solid-ui is the best fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just in case we need it.