Skip to content

refactor for new file explorer setup - #232

Merged
SharonStrats merged 6 commits into
stagingfrom
task/restructure
Oct 23, 2026
Merged

SharonStrats merged 6 commits into
stagingfrom
task/restructure

Conversation

@SharonStrats

@SharonStrats SharonStrats commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

The file explorer header changed a bit because of feedback, also I changed the provider to be headless as well to address feedback Noel had raised.

The content fetch was moved to solid-logic

@SharonStrats
SharonStrats requested a balanced review from Copilot October 22, 2026 05:59
@SharonStrats SharonStrats self-assigned this Oct 22, 2026
@SharonStrats SharonStrats added the enhancement New feature or request label Oct 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Unresolved editor lifecycle and synchronization issues can leave stale content or inconsistent editing state and risk saving text to the wrong resource.

4 open issues
What changed in this PR

Refactors the Source pane to integrate with the shared file explorer context, using a headless provider and a lazily loaded editor.

Changes:

  • Adds editor registration and resource synchronization through shared contexts.
  • Moves resource loading to solid-logic and updates dependencies.
  • Adds JavaScript file selection and file-creation handling, with integration documentation and tests.
File Description
test/​sourceProvider.test.js Tests registration lifecycle, context updates, and editing delegation.
test/​sourcePane.test.js Tests lazy loading, JavaScript selection, and file creation.
test/​sourceEditorCard.test.js Tests deferred initialization and resource switching.
test/​helpers.test.js Removes tests for the deleted local resource loader.
src/​sourcePane.ts Lazily mounts the editor and adjusts selection and creation behavior.
src/​resourceLoader.ts Removes resource-loading helpers replaced by solid-logic.
src/​primitives/​context.ts Adds resource URI and loading state to source context.
src/​components/​source-provider/​SourceProvider.ts Adopts shared explorer registration and slotted editor content.
src/​components/​source-provider/​SourceProvider.styles.css Removes provider layout styles.
src/​components/​source-editor-card/​SourceEditorCard.ts Adds context-driven initialization and resource synchronization.
README.md Documents explorer integration and JavaScript selection.
package.json Updates pane registry and resource logic dependencies.
package-lock.json Records dependency and toolkit resolution changes.

Review effort: Balanced

Comment thread src/components/source-editor-card/SourceEditorCard.ts
Comment thread src/components/source-editor-card/SourceEditorCard.ts Outdated
Comment thread src/components/source-editor-card/SourceEditorCard.ts Outdated
Comment thread src/components/source-provider/SourceProvider.ts
…istry@5.0.2-0 solid-ui@5.0.2-2) (latest: rdflib@2.4.1)
@SharonStrats SharonStrats moved this to In review in SolidOS NLNet UI Oct 22, 2026
github-actions Bot and others added 2 commits October 23, 2026 07:05
@SharonStrats
SharonStrats merged commit 3d04249 into staging Oct 23, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in SolidOS NLNet UI Oct 23, 2026
@SharonStrats
SharonStrats deleted the task/restructure branch October 23, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants