Repository navigation
refactor for new file explorer setup - #232
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved editor lifecycle and synchronization issues can leave stale content or inconsistent editing state and risk saving text to the wrong resource.
4 open issues
What changed in this PR
Refactors the Source pane to integrate with the shared file explorer context, using a headless provider and a lazily loaded editor.
Changes:
- Adds editor registration and resource synchronization through shared contexts.
- Moves resource loading to
solid-logicand updates dependencies. - Adds JavaScript file selection and file-creation handling, with integration documentation and tests.
| File | Description |
|---|---|
test/sourceProvider.test.js |
Tests registration lifecycle, context updates, and editing delegation. |
test/sourcePane.test.js |
Tests lazy loading, JavaScript selection, and file creation. |
test/sourceEditorCard.test.js |
Tests deferred initialization and resource switching. |
test/helpers.test.js |
Removes tests for the deleted local resource loader. |
src/sourcePane.ts |
Lazily mounts the editor and adjusts selection and creation behavior. |
src/resourceLoader.ts |
Removes resource-loading helpers replaced by solid-logic. |
src/primitives/context.ts |
Adds resource URI and loading state to source context. |
src/components/source-provider/SourceProvider.ts |
Adopts shared explorer registration and slotted editor content. |
src/components/source-provider/SourceProvider.styles.css |
Removes provider layout styles. |
src/components/source-editor-card/SourceEditorCard.ts |
Adds context-driven initialization and resource synchronization. |
README.md |
Documents explorer integration and JavaScript selection. |
package.json |
Updates pane registry and resource logic dependencies. |
package-lock.json |
Records dependency and toolkit resolution changes. |
Review effort: Balanced
SharonStrats
force-pushed
the
task/restructure
branch
from
October 22, 2026 08:44
18bbd91 to
da20e16
Compare
…istry@5.0.2-0 solid-ui@5.0.2-2) (latest: rdflib@2.4.1)
timea-solid
approved these changes
Oct 22, 2026
…istry@5.0.2-1 solid-ui@5.0.2-2) (latest: rdflib@2.4.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


The file explorer header changed a bit because of feedback, also I changed the provider to be headless as well to address feedback Noel had raised.
The content fetch was moved to solid-logic