Preserve model landing handoffs in Playground - #673
Open
think-back wants to merge 3 commits into
Open
Conversation
Constraint: Model landing actions must open Console Playground with a draft prompt instead of triggering generation immediately. Rejected: Reusing the previous generate search flag | It caused auto-submit behavior and did not keep the prompt editable. Confidence: high Scope-risk: moderate Tested: bun test src/features/playground/index.test.tsx src/routes/_authenticated/playground/-index.test.ts Not-tested: Browser-level staging clickthrough against deployed Console.
Constraint: Landing page CTA must carry model and prompt into /playground without nested sign-up redirect state. Rejected: Keeping /sign-up?redirect=/playground | It prevents a direct Playground handoff and keeps replayable state nested. Confidence: high Scope-risk: narrow Tested: bun test src/components/model-landing-page.test.tsx Not-tested: Browser-level staging clickthrough against deployed Website and Console.
Constraint: The handoff must preserve the landing model id and prompt as editable Playground input without auto-submission. Rejected: Covering only URL validation | It would miss the filtered-model and first-render Playground state regressions. Confidence: high Scope-risk: narrow Tested: bun test src/features/playground/index.test.tsx src/features/playground/lib/playground-handoff.test.ts src/routes/_authenticated/playground/-index.test.ts; bun test src/components/model-landing-page.test.tsx Not-tested: Full e2e browser automation against staging.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/playgroundwith the landing model id and example prompt in search params.gpt-image-2.Test Plan
bun test src/features/playground/index.test.tsx src/features/playground/lib/playground-handoff.test.ts src/routes/_authenticated/playground/-index.test.tsfromweb/default(12 pass)bun test src/components/model-landing-page.test.tsxfromwebsite(3 pass)bun run typecheckfromweb/defaultbun run typecheckfromwebsitebun x eslint src/features/playground/hooks/use-playground-state.ts src/features/playground/index.tsx src/features/playground/lib/index.ts src/routes/_authenticated/playground/index.tsx src/features/playground/index.test.tsx src/features/playground/lib/playground-handoff.ts src/features/playground/lib/playground-handoff.test.tsfromweb/defaultbun x eslint src/components/model-landing-page.tsx src/components/model-landing-page.test.tsxfromwebsitebun run build:checkfromweb/defaultbun run buildfromwebsitegit diff --checkKnown baseline failures
web/default: fullbun testreports1254 pass / 11 fail; failures remain in SMTP settings, subscription purchase/payment request-id tests, subscription fallback normalization, and refundable billing display tests outside this change.website: fullbun testreports202 pass / 6 fail; failures remain in Japanese contact copy, docs link settings, and perf metrics default group proxy tests outside this change.Not tested