fix(sql): quote remaining reserved-word identifiers (key/value/trigger) - #688
Merged
Conversation
Follow-up to #687. With the fatal `trigger` parse error cleared, startup progressed far enough to surface the next one: recall lifecycle enrollment maintenance failed: Error 1064 near 'key = ? ORDER BY `options`.`key` LIMIT 1' KEY and VALUE are reserved in MySQL 8.0, so raw-string predicates like `WHERE key = ?` fail at parse time. GORM quotes identifiers it builds itself, but not ones passed as literal SQL strings. Quote all remaining bare occurrences (10 sites across 6 files), including two `trigger` references inside JOIN/qualified predicates that #687 missed because they carry a table prefix. Verified: go build ./model/ ./service/ ./controller/ passes; a repo wide re-scan finds no further bare reserved words in SQL strings.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.