Preserve query-local BFCL date arguments - #60
Closed
SonAIengine wants to merge 25 commits into
Closed
Conversation
Owner
Author
|
Closing this internal stacked PR as superseded by the current main branch. The branch is preserved for history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bfcl-027-gate,bfcl-027-gate-check,bfcl-028-gate, andbfcl-028-gate-checkxgen-scale-0.28gatedocs/integrations/xgen-api-collection.mdxgen-0.28result as a research failure target, not a README/public headlinerecall_at_k,all_tools_found_at_k,argument_schema_coverage_at_k) so selector/rerank upper bounds can be checked before another full model runLatest BFCL 0.28 Full Result
/tmp/gtc-bfcl-028-gate-full-qwen.jsonqwen3.6-27b, local BFCL-compatible evaluatorfail0.865vs threshold0.870.953vs threshold0.960.904497vs threshold0.960.730vs threshold0.78/tmp/gtc-bfcl-028-failure-inspect.jsontop_k=30givesall_tools_found_at_k=0.901099,recall_at_k=0.937729, while fixed top-5 all-tools-found is0.274725Verification
git diff --checkpoetry run ruff check .poetry run ruff format --check .poetry run pytest tests/ -qmake research-check-unitmake research-checkmake -n bfcl-027-gatemake -n bfcl-028-gatemake bfcl-027-gate-check REPORT=/tmp/gtc-bfcl-date-guidance-limit25-repeat3-row-retrieved-qwen.jsonpassmake bfcl-028-gate-check REPORT=/tmp/gtc-bfcl-date-guidance-limit25-repeat3-row-retrieved-qwen.jsonfails as expected for partial scopeOUT_DIR=/tmp/gtc-x2bee-openapi-snapshot-028 make xgen-scale-snapshotMANIFEST=/tmp/gtc-x2bee-openapi-snapshot-028/manifest.json make xgen-scale-snapshot-checkMANIFEST=/tmp/gtc-x2bee-openapi-snapshot-028/manifest.json GATE_PROFILE=xgen-scale-0.28 OUT=/tmp/gtc-x2bee-scale-snapshot-sweep-028.json TOP_KS=3,5,10 make xgen-scale-sweepmake xgen-scale-028-gate-check REPORT=/tmp/gtc-x2bee-scale-snapshot-sweep-028.jsonpassLIMIT=1 REPEATS=1 TOOL_SOURCES=retrieved FAIL_ON_GATE=0 OUT=/tmp/gtc-bfcl-028-endpoint-smoke.json CACHE_DIR=/tmp/gtc-bfcl-028-endpoint-smoke-cache make bfcl-028-gatepass over partial smoke casesFAIL_ON_GATE=0 CACHE_DIR=/tmp/gtc-bfcl-date-guidance-limit25-repeat3-row-retrieved-cache-v19 OUT=/tmp/gtc-bfcl-028-gate-full-qwen.json CONCURRENCY=6 PROGRESS_EVERY=50 make bfcl-028-gatecompleted, gate fail as documentedmake bfcl-028-gate-check REPORT=/tmp/gtc-bfcl-028-gate-full-qwen.jsonfail as documentedmake bfcl-failure-subset REPORT=/tmp/gtc-bfcl-028-gate-full-qwen.json OUT=/tmp/gtc-bfcl-028-failure-case-ids.txtmake bfcl-inspect-failures REPORT=/tmp/gtc-bfcl-028-gate-full-qwen.json OUT=/tmp/gtc-bfcl-028-failure-inspect.json TOP_K=5 INSPECT_DEPTH=30 TOOL_SOURCES=retrieved REPORT_TOP_KS=5poetry run pytest tests/test_bfcl_tool_selection_benchmark.py tests/test_bfcl_tool_selection_failures.py tests/test_bfcl_tool_selection_hard_cases.py -qpoetry run python -m benchmarks.bfcl_tool_selection.run --categories simple_python,multiple,parallel,parallel_multiple --top-k 30 --case-ids-file /tmp/gtc-bfcl-028-failure-case-ids.txtDocs-only commit
fd126fb: no additional code tests were required after that commit;git diff --checkwas run. Commitfdbcbdaadds benchmark metrics and was verified with targeted ruff/pytest plus the deterministic failure-subset run above.