Repository navigation
Remove deprecated Homebrew cleanup hook and keep full uninstall in the app - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homebrew emits a deprecation warning when loading LeftOpen's uninstall_preflight hook. Remove that hook from the release template: Homebrew removes the app and CLI, while Settings → About → Uninstall LeftOpen performs complete service, certificate and settings cleanup before package removal.
Add cask caveats and English/Chinese documentation, retaining the app's private handoff for older installation receipts. This aligns future releases with the already-published tap fix (SonghaiFan/homebrew-tap@ad99328).
Validation: 3 Ruby tests / 9 assertions; real Homebrew artifact and JSON receipt integration check; Ruby syntax and diff checks. No real uninstall was executed.