Repository navigation
Generate entity factories with a source generator - #228
Merged
Merged
Conversation
marchc1
requested changes
Oct 26, 2026
| title: "Linked entity class cannot get a generated factory", | ||
| messageFormat: "'{0}' is linked to '{1}' but {2}, so no factory is registered", | ||
| category: "EntityFactories", | ||
| defaultSeverity: DiagnosticSeverity.Warning, |
Member
There was a problem hiding this comment.
We have so many warnings it would get drowned out and it's a pretty serious problem
| return false; | ||
| } | ||
|
|
||
| static bool IsAccessible(INamedTypeSymbol type) { |
Member
There was a problem hiding this comment.
These things are copied from PanelRegistrationGenerator; is there any way we could make a shared helper file for it
marchc1
approved these changes
Oct 27, 2026
Member
|
Do see those comments, but it can wait for now, trying to flush out the open PR's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.