Skip to content

add initial legacy pattern corresponding concept and helper function#74

Draft
yhmtsai wants to merge 1 commit intodev/yhmtsai/tag_viewfrom
dev/yhmtsai/use_tag_view
Draft

add initial legacy pattern corresponding concept and helper function#74
yhmtsai wants to merge 1 commit intodev/yhmtsai/tag_viewfrom
dev/yhmtsai/use_tag_view

Conversation

@yhmtsai
Copy link
Copy Markdown
Contributor

@yhmtsai yhmtsai commented Apr 29, 2026

Summary:
This add some helper function and concept usage such that we can use the legacy pattern information to distinguish the implementation

Details:

  • get_ultimate_base_or_matrix_opt is different than the other kind of get_..._matrix. It stops at the matrix_opt not the matrix_view. We might need both eventually for input with matrix_opt and output with matrix_view
  • We need to keep the reference. Otherwise, when we try to create the matrix_handle in matrix_opt, it use copy constructor such that it leads the handle actually released. (Personally, I would prefer using shared_ptr to let it handle lifetime. Otherwise, we must handle them carefully. Related to matrix_opt need to disable the copy constructor and assignment #67)
  • It introduces has_full to show that we can limit the implementation only when the matrix if full as provided.
  • There is something we need to unify to make consistent behavior but here is the proof of concept about the usage.

Merge Checklist:

  • Passing CI
  • Update documentation or README.md
  • Additional Test/example added (if applicable) and passing
  • At least one reviewer approval
  • (optional) Clang sanitizer scan run and triaged
  • Clang formatter applied (verified as part of passing CI)

@yhmtsai yhmtsai requested a review from spencerpatty April 29, 2026 19:44
@yhmtsai yhmtsai self-assigned this Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant