add initial legacy pattern corresponding concept and helper function#74
Draft
yhmtsai wants to merge 1 commit intodev/yhmtsai/tag_viewfrom
Draft
add initial legacy pattern corresponding concept and helper function#74yhmtsai wants to merge 1 commit intodev/yhmtsai/tag_viewfrom
yhmtsai wants to merge 1 commit intodev/yhmtsai/tag_viewfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This add some helper function and concept usage such that we can use the legacy pattern information to distinguish the implementation
Details:
get_ultimate_base_or_matrix_optis different than the other kind ofget_..._matrix. It stops at the matrix_opt not the matrix_view. We might need both eventually for input with matrix_opt and output with matrix_viewhas_fullto show that we can limit the implementation only when the matrix if full as provided.Merge Checklist: