Conversation
Collaborator
Author
|
@dance858 I looked at the tests carefully and also the implementation, I think it all makes sense, but definitely feel free to clean some stuff up.. I did revert back to using Claude for this unfortunately :(. |
Transurgeon
added a commit
that referenced
this pull request
Apr 23, 2026
* initial iteration for convolve atom * apply formatter * adds test for row convolve in case it is 1d in python * improve convention of data pointer when we have parameters for left and right matmul * get rid of sparse matrix abstraction and just do CSR instead * get rid of block abstraction and use non-block logic instead * happy with convolve.c --------- Co-authored-by: dance858 <danielcederberg1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new atom for the discrete convolution of a kernel (param source) with an expression.