fix(cli): canonical bin path so npm keeps the command on publish - #15
Merged
Conversation
…lish)
npm's publish-time manifest normalization strips a bin value with a leading
"./" ("bin[speechify] script name dist/bin.js was invalid and removed"),
which would serve a packument with no `speechify` command. "dist/bin.js"
is the canonical form and publishes clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
npm publishdry-run for the first release warned:npm's publish-time manifest normalization strips a
binvalue with a leading./, so the served packument would list nospeechifycommand. (The tarball itself keptbin, so a direct tarball install still linked — but the registry manifest is wrong.)Fix: use the canonical
"dist/bin.js"(no./). Verified: dry-run publishes with no warning, tarball installs andspeechify --versionruns. Needed before the first0.0.1publish.