Repository navigation
Smart client handoffs: reinstate auto-enlistment for the hosted providers and remove [Experimental] - #3248
Merged
Conversation
3.3.0 shipped maintenance notifications purely opt-in, with the provider overrides commented out rather than deleted so that what came back would be exactly what was reviewed. This is that, pending the thumbs up. The three overrides return in their original form: Redis Cloud, Azure Managed Redis and Redis Enterprise select Auto, so a connection string naming nothing but a recognized hostname gets the feature. Auto rather than Enabled throughout, because a deployment that cannot deliver has to keep working - the opt-in is refused and the feature stays off, rather than the connection being rejected. The library default stays Disabled: OSS Redis, Valkey and Garnet do not know the subcommand, and an unsolicited error on every connection would be a poor first impression. Docs follow the behaviour back: - ServerMaintenanceEvent's "do I need to configure anything?" returns to "usually not", with the two-column now/will-be table collapsed and the temporary notice dropped. Kept the `defaults=` table row that was added while the feature was opt-in, since it is useful either way. - Configuration.md and exp/SER010.md lose their "purely opt-in" paragraphs. - DefaultOptionsTests.MaintenanceNotificationDefaultPerProvider flips its first two rows to Auto, which is what it was written to do. The last two rows stay Disabled, and they are what stops the theory passing merely because every host returns the same answer. MaintenanceOptInClientTests.DefaultIsOff needed no change: it connects to the in-process server on loopback, which no provider recognizes, so Disabled is still the right answer there. The three API entries go back into Unshipped; eng/public-api.py --check agrees the file is sorted. Also preserved each source file's existing BOM state - RedisEnterpriseOptionsProvider.cs has none, and writing one in would have put an unrelated first-line change in the diff.
The hosted providers now enlist by default, so callers on Redis Cloud, Redis Enterprise and Azure Managed Redis get this behaviour without touching a gated member; keeping the knobs behind [Experimental] no longer made sense. Removed the attribute everywhere, the [SER010] prefix from the PublicAPI entries, and the suppression from NoWarn and the maintenance toys. SER010 is added to the reserved-IDs list in Experiments.cs so it is never recycled. docs/exp/SER010.md stays, since the help URL points at it, rewritten in the retired form. The Redis Enterprise cluster-flag prerequisite that only lived there moves into ServerMaintenanceEvent.md, which also loses its experimental note and its stale "Disabled everywhere, until auto-enlistment lands" wording.
philon-msft
approved these changes
Oct 6, 2026
Co-authored-by: Philo <philon@microsoft.com>
mgravell
added a commit
that referenced
this pull request
Oct 8, 2026
…ER010 (#3248), RetryPolicy doc fix (#3265) Conflicts, resolved in v4 terms: - Directory.Build.props: main retired SER010 from NoWarn; v4 had retired SER013 and still suppresses SER012 and SER014. NoWarn is v4's list without SER010, and the comment names all eight retired IDs (SER011 stays deliberately unsuppressed). - src/RESPite/Shared/Experiments.cs: both retirements recorded - main's SER010 line (MaintenanceNotifications) and v4's SER013 note, whose renumbering explanation now says SER010 has since retired too. The MaintenanceNotifications constant goes, as on main; nothing in v4's own code used it. - src/StackExchange.Redis/PublicAPI/PublicAPI.Unshipped.txt: union of both sides (main's three provider overrides return to Unshipped), then eng/public-api.py sorted it - and RESPite's Unshipped file, which was already out of order on v4. Everything else merged cleanly. Build clean with analyzers on every TFM; RESPite tests pass; main suite net10.0 and net8.0 pass apart from known flakes, plus one unreproduced QueuedResultTests failure noted in the ledger's watch list.
FloatingMilkshake
pushed a commit
to FloatingMilkshake/MechanicalMilkshake
that referenced
this pull request
Oct 9, 2026
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [StackExchange.Redis](https://seredis.dev/) ([source](https://github.com/StackExchange/StackExchange.Redis)) | nuget | minor | `3.3.1` → `3.4.0` | --- ### Release Notes <details> <summary>StackExchange/StackExchange.Redis (StackExchange.Redis)</summary> ### [`v3.4.0`](https://github.com/StackExchange/StackExchange.Redis/releases/tag/3.4.0) [Compare Source](StackExchange/StackExchange.Redis@3.3.1...3.4.0) #### Major Changes - In RESP3, by default the library now uses **separate** connections for pub/sub; see [#​3264](StackExchange/StackExchange.Redis#3264) - Smart-client-handoffs is now enabled by default on Redis Enterprise and AMR; see [#​3248](StackExchange/StackExchange.Redis#3248) - Some logging events incorrectly used duplicated ids - resolved; see [#​3266](StackExchange/StackExchange.Redis#3266) #### All Changes - Recover promptly from a cluster failover; fix the configuration channel under RESP3 and with a channel prefix ([#​3254](StackExchange/StackExchange.Redis#3254)) by [@​mgravell](https://github.com/mgravell) in [#​3255](StackExchange/StackExchange.Redis#3255) - Preserve binary members as VectorSetRange bounds by [@​Laurianti](https://github.com/Laurianti) in [#​3256](StackExchange/StackExchange.Redis#3256) - Smart client handoffs: reinstate auto-enlistment for the hosted providers and remove \[Experimental] by [@​mgravell](https://github.com/mgravell) in [#​3248](StackExchange/StackExchange.Redis#3248) - docs: fix retry-category test in the custom RetryPolicy sample by [@​mgravell](https://github.com/mgravell) in [#​3265](StackExchange/StackExchange.Redis#3265) - Fix duplicate LoggerMessage event ids; add a guard test by [@​mgravell](https://github.com/mgravell) in [#​3266](StackExchange/StackExchange.Redis#3266) - Scan: observe the faults of abandoned page tasks after a sync timeout or dispose ([#​3260](StackExchange/StackExchange.Redis#3260)) by [@​mgravell](https://github.com/mgravell) in [#​3267](StackExchange/StackExchange.Redis#3267) - Report the outcome of every physical connection attempt, identifying the client certificate used by [@​mgravell](https://github.com/mgravell) in [#​3257](StackExchange/StackExchange.Redis#3257) - Use a dedicated pub/sub connection under RESP3 by default by [@​mgravell](https://github.com/mgravell) in [#​3264](StackExchange/StackExchange.Redis#3264) #### Tooling - docs(agents): add create-implementation-plan-for-redis-api-change skill by [@​uglide](https://github.com/uglide) in [#​3268](StackExchange/StackExchange.Redis#3268) #### New Contributors - [@​Laurianti](https://github.com/Laurianti) made their first contribution in [#​3256](StackExchange/StackExchange.Redis#3256) **Full Changelog**: <StackExchange/StackExchange.Redis@3.3.1...3.4.0> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xNDkuMCIsInVwZGF0ZWRJblZlciI6IjQ0LjE0OS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://git.milkshake.services/FloatingMilkshake/MechanicalMilkshake/pulls/9 Reviewed-by: Milkshake <floatingmilkshake@noreply.milkshake.services>
FloatingMilkshake
pushed a commit
to FloatingMilkshake/Azusa
that referenced
this pull request
Oct 9, 2026
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [StackExchange.Redis](https://seredis.dev/) ([source](https://github.com/StackExchange/StackExchange.Redis)) | nuget | minor | `3.3.1` → `3.4.0` | --- ### Release Notes <details> <summary>StackExchange/StackExchange.Redis (StackExchange.Redis)</summary> ### [`v3.4.0`](https://github.com/StackExchange/StackExchange.Redis/releases/tag/3.4.0) [Compare Source](StackExchange/StackExchange.Redis@3.3.1...3.4.0) #### Major Changes - In RESP3, by default the library now uses **separate** connections for pub/sub; see [#​3264](StackExchange/StackExchange.Redis#3264) - Smart-client-handoffs is now enabled by default on Redis Enterprise and AMR; see [#​3248](StackExchange/StackExchange.Redis#3248) - Some logging events incorrectly used duplicated ids - resolved; see [#​3266](StackExchange/StackExchange.Redis#3266) #### All Changes - Recover promptly from a cluster failover; fix the configuration channel under RESP3 and with a channel prefix ([#​3254](StackExchange/StackExchange.Redis#3254)) by [@​mgravell](https://github.com/mgravell) in [#​3255](StackExchange/StackExchange.Redis#3255) - Preserve binary members as VectorSetRange bounds by [@​Laurianti](https://github.com/Laurianti) in [#​3256](StackExchange/StackExchange.Redis#3256) - Smart client handoffs: reinstate auto-enlistment for the hosted providers and remove \[Experimental] by [@​mgravell](https://github.com/mgravell) in [#​3248](StackExchange/StackExchange.Redis#3248) - docs: fix retry-category test in the custom RetryPolicy sample by [@​mgravell](https://github.com/mgravell) in [#​3265](StackExchange/StackExchange.Redis#3265) - Fix duplicate LoggerMessage event ids; add a guard test by [@​mgravell](https://github.com/mgravell) in [#​3266](StackExchange/StackExchange.Redis#3266) - Scan: observe the faults of abandoned page tasks after a sync timeout or dispose ([#​3260](StackExchange/StackExchange.Redis#3260)) by [@​mgravell](https://github.com/mgravell) in [#​3267](StackExchange/StackExchange.Redis#3267) - Report the outcome of every physical connection attempt, identifying the client certificate used by [@​mgravell](https://github.com/mgravell) in [#​3257](StackExchange/StackExchange.Redis#3257) - Use a dedicated pub/sub connection under RESP3 by default by [@​mgravell](https://github.com/mgravell) in [#​3264](StackExchange/StackExchange.Redis#3264) #### Tooling - docs(agents): add create-implementation-plan-for-redis-api-change skill by [@​uglide](https://github.com/uglide) in [#​3268](StackExchange/StackExchange.Redis#3268) #### New Contributors - [@​Laurianti](https://github.com/Laurianti) made their first contribution in [#​3256](StackExchange/StackExchange.Redis#3256) **Full Changelog**: <StackExchange/StackExchange.Redis@3.3.1...3.4.0> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xNDkuMCIsInVwZGF0ZWRJblZlciI6IjQ0LjE0OS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://git.milkshake.services/FloatingMilkshake/Azusa/pulls/9 Reviewed-by: Milkshake <floatingmilkshake@noreply.milkshake.services>
11 tasks
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
that maintenance notifications went out purely opt-in.
Nothing here is new behaviour: #3191 built and reviewed this, and the overrides were commented out rather than
deleted precisely so that what came back would be exactly what was reviewed. This is that, so it should read as
a revert of the withholding rather than as a change.
What turns on
something.cloud.redislabs.com,.cloud.redis.io,.redislabs.comAuto)something.redis.azure.net,.redisenterprise.cache.azure.netAuto)defaults=enterprise,defaults=rediscloud,defaults=amrAuto)Auto, notEnabled, throughout: a deployment that cannot deliver has to keep working, so the opt-in isrefused and the feature simply stays off.
Enabledmeans required and rejects such a connection, which is achoice a caller makes deliberately.
The library default stays
Disabled. Only the three hosted providers enlist. OSS Redis, Valkey and Garnetdo not know the subcommand, and an unsolicited error reply on every connection would be a poor first
impression.
Why this is safe to turn on
The evidence from #3191, all against real deployments:
MOVINGhandoffs acted on ~16s before theserver closed the socket, endpoint retirement proven against a real node removal, and the destructive family
(shard, node and proxy failure) run supervised.
emit these yet, so the opt-in is refused with
ERR unknown subcommand 'MAINT_NOTIFICATIONS'. Measured on alive instance, the connection survives that in sync -
PING,ECHO,PINGall correct afterwards -which matters because the opt-in is pipelined with
HELLO,AUTHand theCLIENTcommands before any replyis read. A server that closed the connection, desynchronised the reply stream, or answered a hopeful
+OKwould have made this default harmful rather than merely inert.
AzureManagedRedisOptInTestskeeps thatreproducible, and is written so that the day AMR ships support the same tests report accepted instead.
Changes
PublicAPI.Unshipped.txtregains the three[SER010]overrideentries;eng/public-api.py --checkagrees thefile is sorted.
ServerMaintenanceEvent.mdreturns to "usually not" with the two-columnnow/will-be table collapsed and the temporary notice dropped, and
Configuration.mdandexp/SER010.mdlosetheir "purely opt-in" paragraphs. The
defaults=table row added while the feature was opt-in is kept, sinceit is useful either way.
DefaultOptionsTests.MaintenanceNotificationDefaultPerProviderflips its first two rows toAuto, which iswhat it was written to do. The last two stay
Disabled, and they are what stops the theory passing merelybecause every host returns the same answer.
MaintenanceOptInClientTests.DefaultIsOffneeded no change: it connects to the in-process server on loopback,which no provider recognizes, so
Disabledis still right there.One thing to decide before merging
mainhas since promoted geo-redundant failover out of preview, and maintenance notifications are suppressedinside a multi-group connection - documented as "in development", because how a handoff and a cross-region
failover should agree about who is in charge is not yet settled. With auto-enlistment reinstated, a recognized
Redis Cloud hostname inside a
ConnectGroupAsyncgroup getsAutoand has it suppressed, with a warninglogged. That is the designed behaviour, but it becomes reachable without anyone configuring anything, where
before it needed an explicit
maintNotifications.Verification
dotnet build Build.csprojclean across every TFM. Full suite on two cores in Release withCI=true: 6470passed, 0 failed, 161 skipped.