Repository navigation
Require version bump for changed Claude plugin guidance - #3
Draft
stephen-vakil wants to merge 1 commit into
Draft
stephen-vakil wants to merge 1 commit into
stephen-vakil wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Require a manifest version increase when a public plugin PR changes one of the three SOFA skills,
plugin-guidance.json, or.mcp.json. Compare with the PR base commit on publicmain; an unrelated change can retain the same version. A version decrease always fails. The reviewer still chooses the appropriate patch, minor, or major increment.The check runs in the existing
packageCI job. Full checkout history makes the PR base commit available. This is the public-repo CI requirement for the generated PR workflow in SOFA draft PR #835.Validation
python3 -B -m unittest discover -s scripts -p 'test_*.py' -v— 11 passedpython3 -B scripts/check_package.py --base-sha 6de91dd1d8c34839c1cb4b103951089b5e794262— passedgit diff --check— passedThe new tests failed on the baseline where changed guidance and a version decrease were accepted.
Merge protection
After CI reports the
packagejob on this PR, set that existing job as a required status check on publicmain. The owner approved this separate settings change; no merge is performed here.