SuSiE/mvSuSiE interface up to date with susieR and mvsusieR#483
Merged
danielnachun merged 2 commits intomainfrom Apr 25, 2026
Merged
SuSiE/mvSuSiE interface up to date with susieR and mvsusieR#483danielnachun merged 2 commits intomainfrom
danielnachun merged 2 commits intomainfrom
Conversation
susieR: rename sketch LD parameter from stochastic_ld_sample to sketch_samples in susie_rss_wrapper. mvsusieR: drop hard-coded option overrides that no longer exist on the mvsusieR refactor (precompute_covariances -> precompute_cache with default TRUE; compute_objective, approximate, verbosity removed). Rely on mvsusie defaults for estimate_residual_variance / estimate_prior_variance / estimate_prior_mixture_weights / estimate_prior_method. In the post-processor, read the renamed outcome_names field, compute coef via coef.mvsusie(), and drop b1_rescaled (trivially derivable from alpha, mu, and X_column_scale_factors; documented inline). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
==========================================
- Coverage 88.44% 87.41% -1.03%
==========================================
Files 35 35
Lines 6993 6985 -8
==========================================
- Hits 6185 6106 -79
- Misses 808 879 +71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
susieR: rename sketch LD parameter from stochastic_ld_sample to sketch_samples in susie_rss_wrapper.
mvsusieR: drop hard-coded option overrides that no longer exist on the mvsusieR refactor