Skip to content

[validation] DataFusion #23127 targeted tests#1

Closed
StealthEyeLLC wants to merge 42 commits into
mainfrom
validate/df-23127-20260710
Closed

[validation] DataFusion #23127 targeted tests#1
StealthEyeLLC wants to merge 42 commits into
mainfrom
validate/df-23127-20260710

Conversation

@StealthEyeLLC

Copy link
Copy Markdown
Owner

Temporary draft PR used only to run targeted GitHub Actions validation for apache#23405. It will be closed after the checks are inspected.

StealthEyeLLC and others added 28 commits July 9, 2026 04:57

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces dynamic dictionary key promotion for group-by aggregation. When the number of distinct groups exceeds the capacity of the current dictionary key type (e.g., 256 groups for UInt8), the key type is promoted to a wider type (e.g., UInt16) at runtime. To keep transport schemas stable across repartitioning and coalescing boundaries, partial aggregate batches are sliced and limited to the planned key capacity, preserving the original schema. Final aggregation then combines all groups and dynamically promotes the output key type as needed. I have no feedback to provide as there are no review comments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant