fix: address #902, #903, #904, #905 - #951
Merged
Merged
Conversation
…Ethereum/Solana Closes Stellar-split#902
…ex multi-op invo Closes Stellar-split#904
|
@Mac-5 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: address #902, #903, #904, #905
What was solved
#902 — Implement cross-chain payment bridge client — Ethereum/Solana to Stellar
Implement a cross-chain payment bridge client that moves payments from Ethereum and Solana into Stellar, extending the existing src/bridge.ts surface with core bridging functionality, event handling, and tests.
Addressed:
#903 — Add SDK metrics export in Prometheus format
Implement a Prometheus-format metrics exporter for the SDK, exposing collected SDK metrics via a Prometheus text exposition endpoint/serializer with proper event handling and tests.
Addressed:
#904 — Implement transaction builder helper for complex multi-op invoices
Add a transaction builder helper that composes complex multi-operation invoices into a single Stellar transaction, with event handling hooks and comprehensive tests. The issue is broad, so the contribution should stay focused on a new builder module plus its test file, following existing patterns in src/builder/OperationBuilder.ts and src/tests/.
Addressed:
#905 — Add optional request deduplication by nonce
Add an optional nonce-based request deduplication capability to the SDK so callers can prevent duplicate submission of the same logical request. The feature should be opt-in (disabled by default to preserve existing behavior), expose a small dedup utility/manager, integrate with the existing request/broadcast path, and be covered by tests. Scope is limited to deduplication by nonce; no unrelated refactors, dependency additions, or changes to existing public behavior when the option is off.
Addressed:
Changes
src/adapters/types.ts(modify)src/telemetry.ts(modify)docs/TELEMETRY_HOOKS.md(modify)src/builder/OperationBuilder.ts(modify)src/__tests__/invoiceBatchProcessor.test.ts(modify)src/broadcaster.ts(modify)src/cache.ts(modify)Approach
Issues
Closes #902
Closes #903
Closes #904
Closes #905