fix: address #922, #923, #924, #925 - #954
Merged
Kingsman-99 merged 5 commits intoSep 28, 2026
Merged
Conversation
|
@janetpius-cmd Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: address #922, #923, #924, #925
What was solved
#922 — Implement invoice reconciliation utilities
Implement invoice reconciliation utilities in the Stellar SDK repo: core reconciliation logic (matching invoices against ledger/payment records, detecting discrepancies), event handling for reconciliation lifecycle events, and comprehensive tests. Scope is limited to the stated requirements — no unrelated refactors.
Addressed:
#923 — Add SDK performance profiling built-in
Implement a built-in SDK performance profiling feature that captures timing and performance metrics for SDK operations, exposes an event-based API for profiling lifecycle events, and includes comprehensive tests. The issue is broad, so the contribution should establish a focused, well-typed profiling module with event handling and tests, following existing SDK patterns.
Addressed:
#924 — Implement cross-tenant invoice auditing
Implement cross-tenant invoice auditing as a focused new module in the existing audit subsystem, providing tenant-scoped invoice audit records, event emission, and a test suite. The issue is high-level, so the contribution will add a self-contained auditor (src/audit/CrossTenantInvoiceAuditor.ts) plus tests, following existing patterns in src/audit/AuditTrailHasher.ts and src/auditLogger.ts, without touching unrelated modules.
Addressed:
#925 — Add SDK debug mode with verbose logging
Add an opt-in SDK debug mode that enables verbose logging across the SDK, with proper event handling for debug state changes and comprehensive tests. The feature should be implemented as a focused, reusable debug/logging utility that other modules can consume, without refactoring unrelated code.
Addressed:
Changes
src/channelReconciler.ts(modify)src/telemetryHooks.ts(modify)examples/telemetry-hooks-example.ts(modify)src/audit/AuditTrailHasher.ts(modify)src/auditLogger.ts(modify)src/cache.ts(modify)Approach
Issues
Closes #922
Closes #923
Closes #924
Closes #925