Add custody withdrawal approval workflows, SDK data migration utilities, and advanced compression caching - #955
Merged
Conversation
|
@levi0005 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add custody withdrawal approval workflows, SDK data migration utilities, and advanced compression caching
What was solved
#930 — Implement custody withdrawal approval workflows
Implement custody withdrawal approval workflows in the Stellar SDK codebase, adding core approval-workflow functionality, event handling, and tests. The repo already contains related modules (src/approvalWorkflowSequencer.ts, src/accessControl.ts, src/auditLogger.ts), so the implementation should extend existing patterns rather than introduce a parallel subsystem.
Addressed:
#931 — Add SDK data migration utilities
Add SDK data migration utilities to the Stellar SDK codebase. The issue is high-level and asks for core migration functionality, event handling, and comprehensive tests, with acceptance criteria around implementation, passing tests, TypeScript compilation, and ESLint. Given the existing structure (src/ modules with tests), the contribution should introduce a focused migration utility module plus its test file, following existing patterns.
Addressed:
#932 — Implement advanced SDK caching with compression
Implement advanced SDK caching with compression by extending the existing cache layer (src/cache.ts and src/cache/OptimisticCache.ts) with a compression-aware caching mechanism, including event handling for cache lifecycle events and comprehensive tests. The issue is broad but the concrete deliverable is a compression-enabled cache implementation with tests, scoped to the existing cache modules rather than a repo-wide refactor.
Addressed:
#933 — Add webhook signature validation library
Implement a webhook signature validation library in the existing TypeScript SDK, providing core HMAC-based signature verification, event handling for incoming webhook payloads, and comprehensive tests. The repo already has webhook middleware and security docs, so this should integrate with existing patterns rather than duplicate them.
Addressed:
Changes
src/approvalWorkflowSequencer.ts(modify)src/accessControl.ts(modify)src/auditLogger.ts(modify)src/accountDataManager.ts(modify)src/adapters/types.ts(modify)src/cache.ts(modify)src/cache/OptimisticCache.ts(modify)src/webhookSignatureValidator.ts(create)src/webhookMiddleware.ts(modify)docs/WEBHOOK_SECURITY_FLOW.md(modify)Approach
Issues
Closes #930
Closes #931
Closes #932
Closes #933