fix: address #914, #915, #916, #917 - #959
Merged
Merged
Conversation
|
@dami-005 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: address #914, #915, #916, #917
What was solved
#914 — Implement multi-signature transaction builder
Implement a multi-signature transaction builder in the Stellar SDK codebase, providing core functionality to construct transactions requiring multiple signers, with proper event handling and comprehensive tests. The feature should integrate with existing builder patterns (e.g., src/builder/OperationBuilder.ts) and transaction construction utilities, exposing a clean API for adding signers, setting thresholds/weights, and assembling the final multi-sig transaction.
Addressed:
#915 — Add optional analytics dashboard data export
Add an optional analytics dashboard data export capability to the SDK. The issue is intentionally high-level, so the contribution should introduce a focused, opt-in export module (e.g. serializing analytics/dashboard metrics to a portable format) with event handling hooks and accompanying tests, while keeping the feature strictly optional so existing behavior is unchanged.
Addressed:
#916 — Implement SDK state machine validator
Implement a focused SDK state machine validator that enforces legal state transitions for SDK lifecycle states, with event handling hooks and comprehensive unit tests. The issue is broad, so scope is limited to a single validator module plus its test file, following existing src/ module and tests patterns.
Addressed:
#917 — Add invoice notification subscription manager
Implement an invoice notification subscription manager in the Stellar SDK codebase, providing core subscription management functionality, event handling for invoice notifications, and comprehensive tests, while keeping TypeScript and ESLint clean.
Addressed:
Changes
src/builder/OperationBuilder.ts(modify)src/accounts/AccountSignerWeightCalculator.ts(modify)src/analyticsDashboardExporter.ts(create)src/auditLogger.ts(modify)src/stateMachineValidator.ts(modify)src/__tests__/invoiceBatchProcessor.test.ts(modify)src/broadcaster.ts(modify)Approach
Issues
Closes #914
Closes #915
Closes #916
Closes #917