feat: implement issues #870-#873 (Drips Wave) - #984
Merged
Kingsman-99 merged 2 commits intoSep 28, 2026
Merged
Kingsman-99 merged 2 commits into
Kingsman-99 merged 2 commits into
Conversation
Issue Stellar-split#873 - releasePartial with basis-point validation - Add InvalidBpsError (code: INVALID_BPS) for bps outside 1-10000 - Add OverReleaseError (code: OVER_RELEASE) when total would exceed 10000 bps - Add PartialReleaseResult type { txHash, bps, amountReleased, remaining, totalReleasedBps } - Implement StellarSplitClient.releasePartial(invoiceId, bps) wrapping release_partial Issue Stellar-split#872 - cancelInvoice with pre-payment guard - Add CannotCancelFundedInvoiceError (code: CANNOT_CANCEL_FUNDED_INVOICE) with paidAmount - Implement StellarSplitClient.cancelInvoice(invoiceId) with funded check before any RPC write - Emit invoice:cancelled event on success; add event type to SplitClientEventMap Issue Stellar-split#871 - bumpInvoiceTtl and getTtl - Add InvoiceTerminatedError (code: INVOICE_TERMINATED) for terminal-state invoices - Add TtlInfo type { ttlLedgers, approximateDays, health: TtlHealth } - Add TtlHealth union type ('healthy' | 'warning' | 'critical') - Implement StellarSplitClient.bumpInvoiceTtl(invoiceId) - refuses terminal invoices - Implement StellarSplitClient.getTtl(invoiceId) - returns health-classified TtlInfo Issue Stellar-split#870 - getFundingVelocity with hourly bucket aggregation - Add VelocityBucket type { hour, timestamp, amount } - Implement StellarSplitClient.getFundingVelocity(invoiceId, opts?) - last 168h default - Export computeTrendingScore(buckets) standalone pure function (0-100 score) - Implement StellarSplitClient.isTrending(invoiceId) - score > 70 threshold All new symbols exported from src/index.ts. Tests added in test/drips-wave-issues.test.ts.
|
@ahmadrabiumustapha Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #873 - releasePartial with basis-point validation
Issue #872 - cancelInvoice with pre-payment guard
Issue #871 - bumpInvoiceTtl and getTtl
Issue #870 - getFundingVelocity with hourly bucket aggregation
All new symbols exported from src/index.ts.
Tests added in test/drips-wave-issues.test.ts.
closes #870
closes #871
closes #872
closes #873