Add Spark splat dynamic lighting and line-based point helper

client/packages/editor-oss/src/assets/js/loaders/SparkGaussianSplatLoader.ts

@@ -49,7 +49,7 @@ class SparkGaussianSplatLoader extends BaseLoader {
     async load(url: string, options?: SparkGaussianSplatLoaderOptions): Promise<Object3D> {
         const resolvedUrl = this.resolveUrl(url);
         const packedSplats = await this.getPackedSplats(resolvedUrl, options);
-        const mesh = new SplatMesh({ packedSplats });
+        const mesh = new SplatMesh({ packedSplats, editable: true });
         await mesh.initialized;
 
         mesh.userData.type = 'GaussianSplat';

client/packages/editor-oss/src/helper/light/VolumePointLightHelper.js

@@ -7,9 +7,23 @@
 
 import * as THREE from "three";
 
-class VolumePointLightHelper extends THREE.PointLightHelper {
+class VolumePointLightHelper extends THREE.LineSegments {
     constructor(light, sphereSize, color) {
-        super(light, sphereSize, color);
+        const helperGeometry = new THREE.EdgesGeometry(
+            new THREE.SphereGeometry( sphereSize, 4, 2 ),
+        );
+        const helperMaterial = new THREE.LineBasicMaterial({
+            fog: false,
+            toneMapped: false,
+        });
+
+        super(helperGeometry, helperMaterial);
+
+        this.light = light;
+        this.color = color;
+        this.type = "PointLightHelper";
+        this.matrix = this.light.matrixWorld;
+        this.matrixAutoUpdate = false;
 
         var geometry = new THREE.SphereGeometry(2, 4, 2);
         var material = new THREE.MeshBasicMaterial({
@@ -20,6 +34,8 @@ class VolumePointLightHelper extends THREE.PointLightHelper {
         this.picker = new THREE.Mesh(geometry, material);
         this.picker.name = "picker";
         this.add(this.picker);
+
+        this.update();
     }
 
     raycast(raycaster, intersects) {
@@ -40,7 +56,18 @@ class VolumePointLightHelper extends THREE.PointLightHelper {
         }
         delete this.picker;
 
-        super.dispose();
+        this.geometry.dispose();
+        this.material.dispose();
+    }
+
+    update() {
+        this.light.updateWorldMatrix(true, false);
+
+        if (this.color !== undefined) {
+            this.material.color.set(this.color);
+        } else {
+            this.material.color.copy(this.light.color);
+        }
     }
 }
 

client/packages/editor-oss/src/render/EffectRenderer.js

@@ -40,6 +40,7 @@ import {patchPassNode} from "./postprocessing/patchPassNode";
 import {patchShadowNode} from "./postprocessing/patchShadowNode";
 import {outline} from "./postprocessing/SharedDepthOutlineNode";
 import {disposeSparkComposite, ensureSparkComposite} from "./SparkCompositeBridge";
+import {createSparkSceneLightingBridge} from "./SparkLightingBridge";
 // TODO(@stem/editor-oss migration): these subsystems still live in
 // @web-shared. They will move into editor-oss in a follow-up sub-step; the
 // @web-shared alias is allowed during the migration window.
@@ -171,6 +172,7 @@ class EffectRenderer extends BaseRenderer {
         this.height = 0;
         this.pixelRatio = 1;
         this.sparkComposite = null;
+        this.sparkLighting = null;
     }
 
     /**
@@ -209,6 +211,8 @@ class EffectRenderer extends BaseRenderer {
         // Initialize cached canvas size synchronously before the first render
         const canvas = this.renderer && this.renderer.domElement ? this.renderer.domElement : renderer?.domElement;
         this.sparkComposite = ensureSparkComposite(scene, renderer, helperRoot || scene);
+        this.sparkLighting?.dispose();
+        this.sparkLighting = createSparkSceneLightingBridge(scene);
         try {
             const splatSettings = this.scene?.userData?.rendering?.splat || {};
             if (typeof this.sparkComposite?.setSparkOptions === "function") {
@@ -1449,6 +1453,8 @@ class EffectRenderer extends BaseRenderer {
      * Render
      */
     render() {
+        this.sparkLighting?.update();
+
         if (!this.ready || !this.renderPipeline) {
             // If background is set, we need to clear buffers manually
             if (this.scene.background) {
@@ -1652,6 +1658,8 @@ class EffectRenderer extends BaseRenderer {
 
         this.scene = null;
         this.camera = null;
+        this.sparkLighting?.dispose();
+        this.sparkLighting = null;
         disposeSparkComposite(this.sparkComposite);
         this.sparkComposite = null;
         this.renderer = null;