Harden Markdown conversion and extension permissions - #71
Open
Stem0794 wants to merge 12 commits into
Open
Conversation
Stem0794
marked this pull request as ready for review
August 14, 2026 14:03
Stem0794
marked this pull request as draft
August 14, 2026 14:04
Stem0794
marked this pull request as ready for review
August 14, 2026 14:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
scriptingandactiveTabinjector.jsconversion path and stale vendored Marked 15 bundleserialize-javascriptdependency chainWhy
The repository was shipping Marked 15.0.12 while tests exercised a different 9.x dependency. The shipped parser predated upstream XSS and ReDoS fixes, generated HTML was inserted into Gmail without a final allowlist sanitizer, and the background worker could attempt script injection into whichever tab was active. The review also identified a few lower-risk Gmail integration issues around paste handling, draft targeting, and mutation-observer overhead.
Developer impact
Source installs require Node.js 20+.
npm ciinstalls the exact locked dependency set and generatesvendor/marked.umd.jsfrom the pinned Marked version.npm run build:ziprefreshes that generated bundle before packaging.Validation
GitHub Actions passes all required checks on the final PR head:
npm cinpm audit --audit-level=low— 0 vulnerabilitiesnpm test— 62 unit/security tests passingnpm run test:e2e— 88 Playwright tests passingnpm run build:zip— Chrome Web Store package builds successfully