ci: gate all branches, bound job runtime, drop stale-restore cache - #132
Merged
Merged
Conversation
Harden the API pipeline without changing what passes/fails:
- Trigger on push and pull_request for all branches ("**") instead of
only `main`, so feature branches are verified before they reach a PR.
- Add `timeout-minutes: 15` to the build-test job. Previously an unset
timeout let a hung build or test run to GitHub's 6-hour default,
silently burning Actions minutes.
- Remove the explicit `node_modules` cache step. `npm ci` wipes
node_modules before installing, so caching the folder is largely
wasted, and its `restore-keys: node-modules-` fallback could restore
a node_modules built from a different lockfile. `setup-node`'s
`cache: 'npm'` already caches the npm download cache correctly for
reproducible `npm ci` installs.
Build (`nest build`) and test (`jest`, 40 spec files) steps are
unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.