fix(deps): remediate high/moderate audit advisories (no breaking changes) - #133
Merged
Merged
Conversation
…changes
Targeted npm update of in-range transitive advisories plus a multer floor bump, avoiding the fastify v4->v5 and legacy-stellar-sdk migrations. Clears 7 high (axios, brace-expansion, browserslist, fast-uri, ip-address, multer, @nestjs/platform-express), all 4 moderate (hono, @hono/node-server, qs, baseline-browser-mapping), and the 1 low (body-parser).
multer: bumped ^2.1.1 -> ^2.4.0 (advisory affects <=2.2.0) and pinned via overrides { multer: $multer } so @nestjs/platform-express's nested copy dedupes to the patched 2.4.0 too. Same-major, API-compatible.
Deferred to dedicated migration PRs (no safe in-range fix): the fastify v5 cluster (fastify, @fastify/static, find-my-way, @nestjs/platform-fastify, @nestjs/swagger); the legacy stellar-sdk -> @stellar/stellar-sdk migration (+ its vulnerable toml dep); and js-yaml (fix lands only in the 5.x major, not backported to the 3.x/4.x lines the tree uses; reachable only via developer-controlled YAML).
Audit: 20 -> 8 total (high 15->8, moderate 4->0, low 1->0). Verified: npm ci + nest build + jest (39 suites / 460 tests) all pass. Only package.json and package-lock.json changed.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Security remediation of the in-range, non-breaking slice of the API's dependency advisories, delivered ahead of the larger framework migrations so the safe fixes land now.
Fixed —
npm audit20 → 8axios,brace-expansion,browserslist,fast-uri,ip-address,multer,@nestjs/platform-expresshono,@hono/node-server,qs,baseline-browser-mappingbody-parserMechanism: targeted
npm updateof the in-range transitive advisories (patches each instance within its parent's accepted range —brace-expansion/fast-uri/js-yamllive at multiple majors), plus a multer floor bump^2.1.1 → ^2.4.0(advisory affects<=2.2.0) pinned withoverrides: { "multer": "$multer" }so@nestjs/platform-express's nested copy dedupes to the patched2.4.0. Deliberately notnpm audit fix— that churns the@nestjs/platform-fastifyplugin cluster and trips the@fastify/staticv9↔v10 peer conflict.Deferred — dedicated migration PRs (no safe in-range fix)
fastify,@fastify/static(→v10),find-my-way,@nestjs/platform-fastify,@nestjs/swagger. The root still declaresfastify ^4while@nestjs/platform-fastify@11bundles fastify 5 — a genuine v4→v5 migration.stellar-sdk ^11→@stellar/stellar-sdk(npm's only offered "fix" is a bogus downgrade to0.2.1) plus its vulnerabletomldependency.@nestjs/swagger, eslint, istanbul). Reachable only through developer-controlled YAML (OpenAPI generation, lint/nyc config), not user input.Test plan
npm ci(strict, from the regenerated lock) — passes; lock ↔ manifest in syncnpm run build(nest build) — passesnpm test— 39 suites / 460 tests pass (incl. multer-backed upload paths and the auth/admin guards)package.json+package-lock.jsonchanged