fix(security): persist lockout state across app relaunch - #63
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #39
The security store held
isLockedandfailedAttemptsin memory only, so killing and relaunching the app reset the failed-attempt count to zero — a user could bypass the 3-attempt lockout by relaunching between guesses. This persists both fields to SecureStore (localStorage on web), restores them on launch before the app renders, and clears them on sign-out. The attempt-count/lockout policy is extracted into a pure, unit-testedsrc/security/lockout.tsand reused by the biometric gate.This repo is for the React Native mobile app only
Note:
localStorageis used only inside the SecureStore adapter'sPlatform.OS === 'web'branch, mirroring the existingstores/auth.store.tspattern — not in a screen or component.Type of change
Testing
New
src/security/lockout.test.tscovers the count-up, threshold, past-threshold, and malformed-input cases.hydrate()is wired intoapp/_layout.tsxalongside the existing auth/user hydration and the render is gated on it so a locked session is never briefly shown unlocked; the auto-lock effect now waits for security hydration to avoid a rehydrate race.npm run typecheck,npm test,npm run lint, andnpx expo export --platform weball pass.Context files reviewed