fix(auth): clear in-memory loans on sign-out - #64
Merged
Merged
Conversation
The wallet session, user profile, and auth tokens were all cleared on sign-out, but the loans store was left populated in memory. On a shared device the next account would briefly see the previous user's loans until a refresh replaced them. Call clearLoans() alongside clearUser()/clearAuth() in both full sign-out paths: the Settings sign-out action and the BiometricGate lockout logout. The pre-auth wallet disconnect on the sign-in screen is left untouched (no loans are loaded before authentication).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #41
Sign-out cleared the wallet session, user profile, and auth tokens, but the loans store stayed populated in memory. On a shared device the next account could briefly see the previous user's loans until a refresh replaced them. This adds
clearLoans()to both full sign-out paths, completing the sign-out teardown noted as the remaining follow-up on #41 (the WalletConnect-disconnect core was already resolved).This repo is for the React Native mobile app only
This app targets learners only.
Sponsor, vendor, and mentor features belong
in StepFi-Web, not here.
Before submitting, confirm your changes belong here:
or Expo code
(window, document, localStorage)
(use constants/colors.ts only)
(use services/ layer only)
and empty states
Type of change
Testing
Context files reviewed
Mandatory before requesting review
This must exit 0:
npx expo export --platform web
Verified:
npx expo export --platform webexits 0;tsc --noEmitclean;npm test26/26 passing;npm run lint0 errors.