Repository navigation
fix(isometric): edit a label in place over its label pill - #16
Open
bcostaaa01 wants to merge 1 commit into
Open
bcostaaa01 wants to merge 1 commit into
bcostaaa01 wants to merge 1 commit into
Conversation
Double-clicking an isometric object opened the text editor on the label's glyph box with a 60px minimum, generic padding and an unscaled font, so a second white box appeared offset over the label. Isometric labels now edit in an overlay that matches the label background pill exactly: same size, corners and fill, centered single-line text at the canvas zoom.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Double-clicking an isometric object opened the text editor on the label's glyph box, then applied a 60px minimum width, generic padding and an unscaled font size. The result was a second white input box offset over the label pill.
For
isometricowners the editor now:labelBackground)Shapes and links keep the existing editor behavior.
Test plan
npm run typecheck,npm run lint(onsrc)