Repository navigation
feat: support the Isometric and Connection block kinds - #6
Merged
Merged
Conversation
stickyflow.js added isometric objects (Isometric) and face-attached links between them (Connection), so files using either were an "unknown block kind" parse error here. Isometric is a leaf canvas object and a valid from:/to: endpoint; Connection gets the same required from/to validation as a Link. Adds the fromFace/toFace, labelOffsetX/Y and labelBackground vocabulary, face value completion, hover docs, outline entries and highlighting.
2 of 4 tasks
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stickyflow.js (Stickyflow/stickyflow.js#13) added isometric objects and face-attached connections. The extension's ported SFL core didn't know either block kind, so any file using them failed with
unknown block kind 'Isometric'.Isometric: leaf canvas object, validfrom:/to:endpoint (also offered in endpoint completion).sizealready accepts a third (depth) value.Connection: same requiredfrom/tovalidation as aLink; diagnostics now name the actual block kind.fromFace/toFace(with face value completion),labelOffsetX/labelOffsetY,labelBackground.Test plan
npm run compile,npm test(74 passing)Isometricblocks and aConnectionresolves with zero errors here and renders with zero diagnostics in stickyflow.js