Implement Steam catalog page with infinite scroll and View Transition API - #288
Merged
Conversation
… update GameCard for navigation support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the Steam catalog page and related UI components, focusing on more robust scroll position restoration, performance optimizations, and code simplification. The most significant changes include replacing the sessionStorage-based scroll restoration with a centralized store approach, removing unnecessary virtualization logic from the catalog grid, and updating GitHub Actions workflows for better caching and flexibility.
Steam Catalog Scroll Restoration and Navigation:
useCatalogScrollRestorationhook (which used sessionStorage) with a new approach that stores and restores the scroll position viauseShellUiStore, making scroll restoration more reliable and centralized. Now, scroll position is saved on navigation and restored on page load, and is also reset when filters change. (apps/desktop/src/features/steam-catalog/pages/SteamCatalogPage.tsx,apps/desktop/src/features/steam-catalog/components/SteamCatalogGridItem.tsx,apps/desktop/src/features/steam-catalog/components/SteamCatalogTrendingHero.tsx,apps/desktop/src/features/steam-catalog/hooks/useCatalogScrollRestoration.ts) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Catalog Grid and Performance Optimizations:
Removed the usage of
@tanstack/react-virtualand custom virtualization logic fromSteamCatalogVirtualizedGrid, simplifying the grid rendering and relying on CSS grid withcontent-visibilityfor performance. This reduces complexity and potential rendering bugs. (apps/desktop/src/features/steam-catalog/components/SteamCatalogVirtualizedGrid.tsx,apps/desktop/package.json) [1] [2] [3] [4]Disabled view transitions for catalog grid items to avoid unnecessary animations and improve perceived performance. (
apps/desktop/src/features/games/GameCard.tsx)UI and Animation Tweaks:
apps/desktop/src/features/steam-catalog/components/SteamCatalogTrendingHero.tsx,apps/desktop/src/styles/App.css) [1] [2] [3]CI/CD Workflow Improvements:
.github/workflows/ci.yml,.github/workflows/release.yml) [1] [2] [3]These changes collectively improve the user experience in the Steam catalog, simplify the codebase, and enhance developer workflows.