Fix multiselect issue with section field by AbdiTolesa · Pull Request #2521 · Strategy11/formidable-forms

AbdiTolesa · 2025-10-01T12:12:52Z

Fix https://github.com/Strategy11/formidable-pro/issues/5229

Test steps

Add a few fields, a Section field and some fields into the section.
Try multi selecting with ctrl + click on fields outside the Section and then try adding the Section field to the selected groups by clicking on the Section header.
Confirm that the section field is selectable with other fields.

CleanShot.2025-10-01.at.16.26.33.mp4

CleanShot.2025-10-01.at.16.16.00.mp4

Summary by CodeRabbit

New Features
- Added Ctrl/Meta-click support for selecting and deselecting field groups in the admin builder.
- Updated the multiselect interface to display the current number of selected groups.
- Prevented group-selection clicks from triggering standard field selection.

coderabbitai · 2025-10-01T12:19:58Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 26b8e095-4f74-4568-ad76-2fd9450a812d

📥 Commits

Reviewing files that changed from the base of the PR and between 889d6af and 34864c4.

📒 Files selected for processing (2)

js/formidable_admin.js
js/src/admin/admin.js

🚧 Files skipped from review as they are similar to previous changes (1)

js/src/admin/admin.js

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

Adds Ctrl/Meta-click handling to the admin field builder. Modifier-clicks toggle the containing field group, update the selected-group count and multiselect UI, and skip normal field selection. Plain clicks retain the existing behavior.

Changes

Admin builder field-group selection

Layer / File(s)	Summary
Field-group selection toggle `js/src/admin/admin.js`	Ctrl/Meta-clicks toggle the containing field group, update the selected-group count and multiselect state, and return before the normal field-selection action.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 34864

This localized change addresses section-field multiselect behavior, and no actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

Strategy11/formidable-forms#3236: Both changes modify field-group behavior in js/src/admin/admin.js, but they affect different functions and workflows.

Suggested labels: run analysis, run tests

Suggested reviewers: crabcyborg

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: fixing multiselect behavior for Section fields.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch issue-5229

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a24133c and 92a1567.

⛔ Files ignored due to path filters (2)

js/formidable-settings-components.js.map is excluded by !**/*.map, !**/*.map
js/formidable_dashboard.js.map is excluded by !**/*.map, !**/*.map

📒 Files selected for processing (1)

js/src/admin/admin.js (1 hunks)

lauramekaj1 · 2025-10-09T11:20:18Z

Hi @AbdiTolesa,
Multi-selecting including the Section field works as expected.
However, when trying to deselect fields in a group selection (e.g., Ctrl + Click to remove one item from the group), it doesn't work properly since the field remains selected.
Please see screen recording for reference:
https://www.loom.com/share/1bd785331c9b44ffa884dd3c3bfa959e

AbdiTolesa · 2025-10-09T14:44:28Z

Hi @AbdiTolesa,
Multi-selecting including the Section field works as expected.
However, when trying to deselect fields in a group selection (e.g., Ctrl + Click to remove one item from the group), it doesn't work properly since the field remains selected.

Hi @lauramekaj1 I just created a separate issue for that: https://github.com/Strategy11/formidable-pro/issues/6029
This PR is just intended to fix multi-select issues for fields inside Section fields.

lauramekaj1 · 2025-10-09T16:05:11Z

Hi @AbdiTolesa,

Multi-selecting including the Section field works as expected.

However, when trying to deselect fields in a group selection (e.g., Ctrl + Click to remove one item from the group), it doesn't work properly since the field remains selected.

Hi @lauramekaj1 I just created a separate issue for that: https://github.com/Strategy11/formidable-pro/issues/6029

This PR is just intended to fix multi-select issues for fields inside Section fields.

@AbdiTolesa ok so I validated that the issue in this PR is fixed. Thank you!

truongwp · 2025-10-10T19:36:56Z

@AbdiTolesa Does this cover this comment? https://github.com/Strategy11/formidable-pro/issues/6029#issuecomment-3387004193

AbdiTolesa · 2025-10-13T13:54:40Z

@AbdiTolesa Does this cover this comment? Strategy11/formidable-pro#6029 (comment)

@truongwp The link takes to the issue created probably for the comment you were referring to, we are tracking that separately anyway.

truongwp · 2025-10-15T11:22:45Z

@AbdiTolesa If I click on the first field, then hold Shift and click on a field inside a section, it selects all fields in the form. Please see this screencast:

Screen.Recording.2025-10-15.at.18.21.37.mov

AbdiTolesa · 2025-10-15T12:46:33Z

@AbdiTolesa If I click on the first field, then hold Shift and click on a field inside a section, it selects all fields in the form. Please see this screencast:

@truongwp We are tracking that issue separately: https://github.com/Strategy11/formidable-pro/issues/6017

truongwp

This looks good now. Thanks @AbdiTolesa!

truongwp · 2025-10-17T16:22:52Z

@AbdiTolesa Please resolve the conflicts with the master branch so we can merge it.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

js/src/admin/admin.js (1)
5690-5694: Keep multi‑select UI in sync on Ctrl/Cmd click

You add the class and return, but don’t call the existing multi‑select sync flow. The popup/controls won’t appear until a later action. Reuse the same path as group clicks by invoking syncAfterMultiSelect immediately.

Apply this minimal change:
-		if ( e?.metaKey || e?.ctrlKey ) {
-			// Add the target to list of selected fields.
-			this.closest( 'ul' ).classList.add( 'frm-selected-field-group' );
-			return;
-		}
+		if ( e?.metaKey || e?.ctrlKey ) {
+			// Add the target to list of selected fields and sync UI state.
+			const ul = this.closest( 'ul.frm_sorting' ) || this.closest( 'ul' );
+			if ( ul ) {
+				ul.classList.add( 'frm-selected-field-group' );
+				const count = jQuery( '.frm-selected-field-group' ).length || 1;
+				syncAfterMultiSelect( count );
+				maybeHideFieldGroupMessage();
+			}
+			return;
+		}
Note: Ctrl/Cmd‑click deselect toggling is tracked in formidable-pro#6029 and can remain out of scope here. Please just verify the popup appears right after the first Ctrl/Cmd click.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a636cfa and 597dea4.

⛔ Files ignored due to path filters (1)

js/formidable-settings-components.js.map is excluded by !**/*.map, !**/*.map

📒 Files selected for processing (1)

js/src/admin/admin.js (1 hunks)

truongwp

This looks good now. Thanks @AbdiTolesa!

deepsource-io · 2026-02-06T15:11:27Z

DeepSource Code Review

We reviewed changes in e4dc1b0...226d435 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Important

Some issues found as part of this review are outside of the diff in this pull request and aren't shown in the inline review comments due to GitHub's API limitations. You can see those issues on the DeepSource dashboard.

PR Report Card

Overall Grade	Security Reliability Complexity Hygiene

Code Review Summary

Analyzer	Status	Updated (UTC)	Details
PHP		Aug 19, 2026 3:39p.m.	Review ↗
JavaScript		Aug 19, 2026 3:39p.m.	Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

coderabbitai · 2026-08-18T13:41:44Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

deepsource-io · 2026-08-19T15:42:10Z

+		 * @param array    $parts Part labels keyed by the show= option value.
+		 * @param stdClass $field The field the parts belong to.
+		 */
+		return apply_filters( 'frm_field_parts_for_shortcodes', $parts, $field );


Function apply_filters invoked with 3 parameters, 2 required

The function call is not valid, which will result in a fatal runtime error.

deepsource-io · 2026-08-19T15:42:10Z

+		require FrmAppHelper::plugin_path() . '/classes/views/shared/errors.php';
+
 		FrmTransLiteListHelper::render_tabs();
 		$wp_list_table->views();


Variable $wp_list_table might not be defined

A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

Fix multiselect issue with section field

92a1567

coderabbitai Bot reviewed Oct 1, 2025

View reviewed changes

Comment thread js/src/admin/admin.js Outdated

Consider multiselecting with ctrl too in the fix

27a59f6

AbdiTolesa mentioned this pull request Oct 1, 2025

Fix multiselecting issue with section field #2186

Closed

AbdiTolesa requested a review from lauramekaj1 October 2, 2025 11:44

lauramekaj1 approved these changes Oct 9, 2025

View reviewed changes

AbdiTolesa requested a review from truongwp October 9, 2025 17:02

truongwp reviewed Oct 15, 2025

View reviewed changes

Comment thread js/src/admin/admin.js Outdated

Remove a check not needed to fix issue-5229

a636cfa

AbdiTolesa requested a review from truongwp October 17, 2025 13:40

truongwp approved these changes Oct 17, 2025

View reviewed changes

truongwp requested a review from Crabcyborg October 17, 2025 16:22

AbdiTolesa added 2 commits October 22, 2025 18:06

Fix merge conflicts

c61b7cd

Build files

597dea4

coderabbitai Bot reviewed Oct 22, 2025

View reviewed changes

AbdiTolesa requested a review from truongwp October 23, 2025 10:55

truongwp approved these changes Oct 30, 2025

View reviewed changes

truongwp mentioned this pull request Oct 30, 2025

Fix range selection that includes fields in section #2527

Open

truongwp requested review from Crabcyborg and removed request for Crabcyborg November 3, 2025 18:10

Crabcyborg added this to the 6.26 milestone Nov 3, 2025

Add fic

caa00aa

AbdiTolesa added 7 commits February 6, 2026 18:14

Reset all other changes

046ddd1

Add back fix

9745523

Delete all *.js.map files

83d7846

Delete all *.js.map files

aeae5b5

Rebuild files

15ecf15

Reshuffle code

c2475ad

Remove null check not needed

aa08534

AbdiTolesa requested a review from Crabcyborg February 6, 2026 15:32

Crabcyborg modified the milestones: 6.29, 6.30 Mar 9, 2026

Crabcyborg modified the milestones: 6.30 (Pricing Fields), 6.31 (PayPal Commerce) Apr 15, 2026

Crabcyborg modified the milestones: 6.31 (Form Action Refresh, PayPal Commerce), 6.32 May 26, 2026

Crabcyborg modified the milestones: 6.32, 6.33 Jun 16, 2026

Crabcyborg modified the milestones: 6.33, 6.34 Jul 14, 2026

Crabcyborg modified the milestones: 6.34, 6.35 Aug 7, 2026

Merge branch 'master' into issue-5229

34864c4

Improvements to mulselect behaviour

c3c5f5e

Crabcyborg added run analysis run tests labels Aug 18, 2026

Crabcyborg added 2 commits August 18, 2026 11:32

Merge branch 'master' into issue-5229

fb8bc7f

Merge master

226d435

deepsource-io Bot reviewed Aug 19, 2026

View reviewed changes

Uh oh!

Conversation

AbdiTolesa commented Oct 1, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test steps

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lauramekaj1 commented Oct 9, 2025

Uh oh!

AbdiTolesa commented Oct 9, 2025

Uh oh!

lauramekaj1 commented Oct 9, 2025

Uh oh!

truongwp commented Oct 10, 2025

Uh oh!

AbdiTolesa commented Oct 13, 2025

Uh oh!

truongwp commented Oct 15, 2025

Uh oh!

AbdiTolesa commented Oct 15, 2025

Uh oh!

Uh oh!

truongwp left a comment

Choose a reason for hiding this comment

Uh oh!

truongwp commented Oct 17, 2025

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

truongwp left a comment

Choose a reason for hiding this comment

Uh oh!

deepsource-io Bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DeepSource Code Review

PR Report Card

Code Review Summary

Uh oh!

coderabbitai Bot commented Aug 18, 2026

Uh oh!

deepsource-io Bot Aug 19, 2026

Choose a reason for hiding this comment

Function apply_filters invoked with 3 parameters, 2 required

Uh oh!

deepsource-io Bot Aug 19, 2026

Choose a reason for hiding this comment

Variable $wp_list_table might not be defined

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AbdiTolesa commented Oct 1, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Oct 1, 2025 •

edited

Loading

deepsource-io Bot commented Feb 6, 2026 •

edited

Loading