Tighten up some noisy findings / error - note + no hint with validation#47
Merged
Merged
Conversation
…ible rule before the user enters input to be accessible, although it might be a good idea in some cases (but not when the length is within the amount someone could reasonably expect the limit). much too noisy, and many PDF-filling interviews would be very cluttered if every field had a visible maxlength before the user started interacting with the form
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
accessibility finding was too broad; maxlength does not require a vis…ible rule before the user enters input to be accessible, although it might be a good idea in some cases (but not when the length is within the amount someone could reasonably expect the limit). much too noisy, and many PDF-filling interviews would be very cluttered if every field had a visible maxlength before the user started interacting with the form
note field is not a "no label" field but was being misidentified as such